Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Decide to use requireComponents or safe unwrap context #3440

Closed
sblatz opened this issue Jun 13, 2019 · 2 comments
Closed

Decide to use requireComponents or safe unwrap context #3440

sblatz opened this issue Jun 13, 2019 · 2 comments
Labels
eng:health Improve code health eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. P5 Never, but will accept a patch wontfix

Comments

@sblatz
Copy link
Contributor

sblatz commented Jun 13, 2019 •
edited by data-sync-user
Loading

Currently we use the two interchangeably throughout the code base and it doesn't seem to have reasoning behind it (or at least reasoning that is transparent to other engineers). I'm of the mind that we should just be using requireComponents so we don't have silent failures.

┆Issue is synchronized with this Jira Task
@sblatz sblatz added the eng:health Improve code health label Jun 13, 2019
@sblatz sblatz added this to the Dev Stories Backlog milestone Jun 13, 2019
@boek boek removed this from the Dev Stories Backlog milestone Jul 17, 2019
@sblatz sblatz added the P5 Never, but will accept a patch label Jul 19, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 30, 2019
@NotWoods
For mozilla-mobile#3440 - Reduce BrowserFragment require calls
b17191a
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 30, 2019
@NotWoods
For mozilla-mobile#3440 - Reduce HomeFragment require calls
22dbc25
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 9, 2019
@NotWoods
For mozilla-mobile#3440 - Reduce BrowserFragment require calls
e2a9f98
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 9, 2019
@NotWoods
For mozilla-mobile#3440 - Reduce HomeFragment require calls
d856918
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 9, 2019
@NotWoods
For mozilla-mobile#3440 - Reduce HomeFragment require calls
348d280
ekager pushed a commit that referenced this issue Sep 10, 2019
@NotWoods @ekager
For #3440 - Reduce BrowserFragment require calls
16115f5
ekager pushed a commit to NotWoods/fenix that referenced this issue Sep 18, 2019
@NotWoods @ekager
For mozilla-mobile#3440 - Reduce HomeFragment require calls
f0be329
boek pushed a commit that referenced this issue Sep 19, 2019
@NotWoods @boek
For #3440 - Reduce HomeFragment require calls
106458c
@ekager ekager added help wanted Help wanted from a contributor. More complex than good first issue. eng:ready Ready for engineering labels Dec 10, 2019
@ekager
Copy link
Contributor

ekager commented Dec 10, 2019 •
edited
Loading

there are still a few context!!s in our codebase that can be converted to requireContext()s or requireComponents() so we can close out this ticket

@data-sync-user data-sync-user changed the title Decide to use requireComponents or safe unwrap context FNX3-17019 ⁃ Decide to use requireComponents or safe unwrap context Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-17019 ⁃ Decide to use requireComponents or safe unwrap context Decide to use requireComponents or safe unwrap context Aug 27, 2020
@stale
Copy link

stale bot commented Feb 23, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 23, 2021
@stale stale bot closed this as completed Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:health Improve code health eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. P5 Never, but will accept a patch wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boek @sblatz @ekager