Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Support Trusted Web Activity #394

Closed
1 task
yoasif opened this issue Feb 6, 2019 · 17 comments
Closed
1 task

Support Trusted Web Activity #394

yoasif opened this issue Feb 6, 2019 · 17 comments
Labels
E2 Estimation Point: easy, half a day to 2 days Feature:PWA Progressive Web App needs:ac Needs Android Component Work

Comments

@yoasif
Copy link
Contributor

yoasif commented Feb 6, 2019

QA team: steps to test are outlined in a comment below.


Why/User Benefit/User Problem

Trusted Web Activities are a way to integrate your web-app content such as your PWA with your Android app using a protocol based on Custom Tabs.

User Story

As a user I want Progressive Web Apps installed from the Google Play store to use my default browser.

What / Requirements

https://docs.google.com/document/d/1XMMJNJO1VUEBn1jGGIf8b-lHZJuZUuZnjQoX5LSmq8c/edit#
https://developers.google.com/web/updates/2017/10/using-twa

Acceptance Criteria (how do I know when I’m done?)

  • I can download a TWA from the Google Play Store and run it in Fenix.

┆Issue is synchronized with this Jira Task

@pocmo
Copy link
Contributor

pocmo commented Feb 7, 2019

Related A-C meta bug:
mozilla-mobile/android-components#1819

@bbinto bbinto added this to the Backlog (After MVP) milestone Feb 8, 2019
@vesta0 vesta0 removed the P2 Upcoming release label Mar 28, 2019
@kbrosnan kbrosnan added Feature:PWA Progressive Web App feature request 🌟 New functionality and improvements labels Apr 29, 2019
@liuche
Copy link
Contributor

liuche commented May 15, 2019

I've added some more details about TWA in the AC bug.

@vesta0 vesta0 removed the feature request 🌟 New functionality and improvements label Jul 2, 2019
@sblatz sblatz added the feature request 🌟 New functionality and improvements label Jul 11, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@NotWoods NotWoods added the needs:ac Needs Android Component Work label Aug 30, 2019
@liuche
Copy link
Contributor

liuche commented Sep 17, 2019

After some discussion w/ the team, it sounds like TWAs are almost ready to ship. This allow users who download TWAs from the Google Play Store to use Fenix.

Things remaining:

* Most of the APIs that we're using are stable, but the mitigation plan is a) revert on AC, b) reach out to Google androidx team, who have been very responsive

NotWoods added a commit to NotWoods/android-components that referenced this issue Sep 17, 2019
NotWoods added a commit to NotWoods/android-components that referenced this issue Sep 17, 2019
@liuche
Copy link
Contributor

liuche commented Sep 17, 2019

@NotWoods question came up in triage, "what TWA features won't work?"

  • Push
  • what else?

Product says let's do this in Nightly only.

@NotWoods
Copy link
Contributor

NotWoods commented Sep 17, 2019

Splash screens also won't work yet. Both notifications and splash screens require APIs only present in the 1.2.0 library, and would make it harder to revert.

TWAs are pretty much custom tabs without the toolbar, so very few changes are needed. I wrote code for hiding the toolbar that’s shared with PWAs already. Generally if it works as a custom tab, it works as a TWA.

@NotWoods
Copy link
Contributor

Updated the TODO list: We have an API key for TWAs ready but its not yet accessible in the codebase. @jonalmeida will be adding it in soon.

@vesta0 vesta0 added could and removed feature request 🌟 New functionality and improvements labels Sep 19, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 19, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 20, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 23, 2019

I think we need follow-up from @liuche on the status of this ticket.

@apbitner
Copy link

I downloaded the first app along with the latest APK and launched the app. This work seems to be behind the scenes so I didn't notice anything that needs to be reviewed from a UX perspective, unless I'm missing something?

@NotWoods
Copy link
Contributor

The UX would be very light, if any. All Chrome does here is display the "Running in Chrome" snackbar.

@apbitner
Copy link

If it's just staying on Nightly then it should be good for now. We may add a 'Running in Firefox' notification at some point.

@bifleming bifleming added the E2 Estimation Point: easy, half a day to 2 days label Sep 25, 2019
@liuche
Copy link
Contributor

liuche commented Sep 25, 2019

Marking E2 for reviewing remaining work, since there's no additional ask from UX.

@NotWoods
Copy link
Contributor

@liuche Should we put QA needed on this issue?

@liuche
Copy link
Contributor

liuche commented Sep 26, 2019

Yes please! But also include a comment with clear "Steps to Reproduce" (including which build flavor or channel they should be on).

@NotWoods
Copy link
Contributor

Steps to reproduce

@NotWoods NotWoods added the eng:qa:needed QA Needed label Sep 26, 2019
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Sep 26, 2019

@NotWoods Using the apks and steps from #394 (comment) I've found the following:

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Sep 26, 2019
@sblatz sblatz modified the milestone: v2.1 Sep 27, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 6, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 8, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 8, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 9, 2019
@sblatz sblatz closed this as completed in 6ec0d46 Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation Point: easy, half a day to 2 days Feature:PWA Progressive Web App needs:ac Needs Android Component Work
Projects
None yet
Development

No branches or pull requests