Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Flicker while navigating through bookmark folders #4487

Closed
AndiAJ opened this issue Aug 2, 2019 · 2 comments
Closed

[Bug]Flicker while navigating through bookmark folders #4487

AndiAJ opened this issue Aug 2, 2019 · 2 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Bookmarks Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue. P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
v3.0

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 2, 2019 •
edited by data-sync-user
Loading

Prerequisites

Create 3 folders. e.g. A, B, C
Move folder B in folder C
Move folder A in folder B

Steps to reproduce

  1. Tap to open folder C
  2. Tap to open folder B
  3. Tap to open folder A

Expected behavior

No UI issues, the correct folder name is displayed in the control bar

Actual behavior

While navigating through the folders, the folder name flickers, sometimes showing "Bookmarks" instead of the actual bookmarks folder name

Device information

  • Android device:
    • Google Pixel 3a (Android 9)
    • Huawei Mate 20 Lite (Android 8.1.0)

  • Fenix version:
    • RC 1.2-rc2
    • Nightly Build #12140610 from 2/8

Notes

► Video
20190802_140832

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks labels Aug 2, 2019
@boek boek added the P2 Upcoming release label Aug 6, 2019
@AndiAJ AndiAJ added the S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist label Oct 30, 2019
@ekager ekager added Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue. eng:ready Ready for engineering labels Nov 1, 2019
@mcarare mcarare self-assigned this Nov 4, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 4, 2019
@mcarare
For mozilla-mobile#4487 Set activity title only once in Bookmark frag…
59dbbbb 
…ment

Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
ekager pushed a commit that referenced this issue Nov 12, 2019
@mcarare @ekager
For #4487 Set activity title only once in Bookmark fragment
f6a6656 
Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
@ekager ekager added the eng:qa:needed QA Needed label Nov 12, 2019
@ekager ekager added this to the v3.0 milestone Nov 12, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 15, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Nov 15, 2019

Hi, verified as fixed on the latest Nightly Build #13190606 from 11/15 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20191115_144803

@AndiAJ AndiAJ closed this as completed Nov 15, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Dec 5, 2019

Reproducible on 3.0.0-beta.2 Build #13390410 from 12/5 using a Google Pixel 3a (Android 9)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Bookmarks Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue. P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
4 participants
@boek @ekager @mcarare @AndiAJ