Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Fenix widget can't be added on Android 6 devices #4894

Closed
AndiAJ opened this issue Aug 23, 2019 · 4 comments
Closed

[Bug]Fenix widget can't be added on Android 6 devices #4894

AndiAJ opened this issue Aug 23, 2019 · 4 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified feature:SearchWidget S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 23, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Long tap on the home screen of your device
  2. Select widgets
  3. Touch and hold the Firefox Preview widget & move it to your home screen

Expected behavior

Widget can be added to the home screen of the device and can be used properly

Actual behavior

Instead of the actual Firefox Preview widgets a Black bar shows up saying "Problem loading the widget"
rsz_screenshot_20190823-1124366666666

Device information

  • Android device:
    • Samsung Galaxy S6 (Android 6)
    • OnePlus A3 (Android 6.0.1)
    • Huawei P9 Lite (Android 6)

  • Fenix version: 1.0.1934 (Build # 1) 📦: 10.0.0, 1c652634c GV: 70.0a1-20190822095439 from 23/8

Notes

►Video from Samsung Galaxy S6

ezgif com-video-to-gif

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist feature:SearchWidget labels Aug 23, 2019
@BlindMoon38
Copy link

Same in TP-Link Neffos C5 Max, Android 5.1.0

1.0.1934 (Build #1)
📦: 10.0.0, 1548b663a
GV: 70.0a1-20190821095414

@mcarare mcarare self-assigned this Aug 26, 2019
@mcarare
Copy link
Contributor

mcarare commented Aug 26, 2019

@jyeontaek gradient is not supported for vector drawables below SDK 24. Do you have any solution besides adding a different vector for versions below 24?

mcarare added a commit to mcarare/fenix that referenced this issue Aug 27, 2019
@mcarare
Fixes mozilla-mobile#4894: added workaround for SDK<24 vector drawabl…
4f13f68 
…e with gradient color

Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
@NotWoods
Copy link
Contributor

@mcarare We can use vector drawable compat to load the icons with gradients. Replacing android:background with app:srcCompat should be sufficient.

mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2019
@mcarare
Fixes mozilla-mobile#4894: added workaround for SDK<24 vector drawabl…
fdb7728 
…e with gradient color

Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
@boek boek closed this as completed in 9b911f3 Aug 29, 2019
@mcarare mcarare added the eng:qa:needed QA Needed label Aug 30, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 4, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Sep 4, 2019

Hi, verfied as fixed on Fenix Nighlty Build #12470611 from 4/9 using the following devices:
• Samsung Galaxy S6 (Android 6.0.1)
• OnePlus A3 (Android 6.0.1)

►Video
20190904_125030

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified feature:SearchWidget S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NotWoods @BlindMoon38 @mcarare @AndiAJ