Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Meta] Bring additional Lockwise Features to the browser #5774

Closed
4 tasks done
vesta0 opened this issue Oct 3, 2019 · 9 comments
Closed
4 tasks done

[Meta] Bring additional Lockwise Features to the browser #5774

vesta0 opened this issue Oct 3, 2019 · 9 comments
Labels
Feature:Logins Lockwise needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 3, 2019

User Story

As a user, I want to manage my Lockwise credentials for websites in my Firefox for Android Browser.

Acceptance Criteria

┆Issue is synchronized with this Jira Task

@ekager ekager changed the title [Meta] Advanved login management [Meta] Advanced login management Oct 3, 2019
@changecourse
Copy link

Does there also need to be a bullet for hide/show of password?

@liuche
Copy link
Contributor

liuche commented Oct 16, 2019

Does there also need to be a bullet for hide/show of password?

See #5544! That will be part of basic login management, and this issue is tracking the next set of features.

@liuche
Copy link
Contributor

liuche commented Oct 16, 2019

@AmyYLee I see the option to "sort by most recently used" in the options for Logins (P4 in the top comment). I'm concerned that that would leak history in the case that

  1. I visit a site that needs a login, and I autofill (which is "using" the login)
  2. I clear history because I don't want that site in my history
  3. I go to Logins and sort by "most recent" and then that login would show up first (because logins doesn't have a concept of "history".

@AmyYLee
Copy link
Collaborator

AmyYLee commented Oct 21, 2019

@AmyYLee I see the option to "sort by most recently used" in the options for Logins (P4 in the top comment). I'm concerned that that would leak history in the case that

1. I visit a site that needs a login, and I autofill (which is "using" the login)

2. I clear history because I don't want that site in my history

3. I go to Logins and sort by "most recent" and then that login would show up first (because logins doesn't have a concept of "history".

@liuche @ekager We can move the PIN/Biometrics authentication one level up and have this required when the user taps "Saved logins" in the Logins and passwords screen.

@vesta0 vesta0 added the needs:ac Needs Android Component Work label Oct 23, 2019
@vesta0 vesta0 added should and removed must labels Oct 24, 2019
@vesta0 vesta0 added could and removed should labels Nov 4, 2019
@vesta0 vesta0 added 🙅 waiting Issues that are blocked or has dependencies that are not ready feature request 🌟 New functionality and improvements and removed could labels Nov 5, 2019
@AndiAJ AndiAJ mentioned this issue Nov 20, 2019
7 tasks
@abodea
Copy link
Member

abodea commented Apr 10, 2020

Hi, @vesta0 @liuche do you consider that it is worth adding information in Fenix regarding all the accounts saved while not being connected to the FxA?
Please note that while saving any logins while not being logged in, after connecting to the FxA everything will be synced and the accounts will be saved.
As the save login is displayed all the time when login with a new account, it can be confusing for some users as the information regarding the account being saved is not present in the app.
I added this feature request in case this will take into consideration #9847.

@vesta0
Copy link
Collaborator Author

vesta0 commented Apr 17, 2020

Thank you for filing that feature request!

@vesta0 vesta0 changed the title [Meta] Advanced login management [UX] [Meta] Bring additional Lockwise Features to the browser Jun 29, 2020
@s-ankur
Copy link
Contributor

s-ankur commented Aug 14, 2020

Please also consider #13839 Search Logins by Username as this is also a feature available in Lockwise

@AmyYLee
Copy link
Collaborator

AmyYLee commented Aug 19, 2020

cc @violasong who will be taking over logins work

@AmyYLee AmyYLee removed their assignment Aug 19, 2020
@vesta0 vesta0 changed the title [UX] [Meta] Bring additional Lockwise Features to the browser [Meta] Bring additional Lockwise Features to the browser Oct 12, 2020
@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 12, 2020

The user stories outlined in this meta have been completed. Thanks team!

@vesta0 vesta0 closed this as completed Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:Logins Lockwise needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

6 participants