Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Don't prompt user to login if they select "Never Save" in password prompt #7094

Closed
3 tasks done
liuche opened this issue Dec 11, 2019 · 13 comments
Closed
3 tasks done
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Logins

Comments

@liuche
Copy link
Contributor

liuche commented Dec 11, 2019

Why/User Benefit/User Problem

As a user, if I don't want to save a login, I don't want to be prompted again.

Breaking this out of #5542

Dependencies

  • UX to provide context between "Don't save" and "Never save"

Acceptance Criteria (how do I know when I’m done?)

  • Clicking "Don't Save" on the logins prompt does not show the prompt again
  • Exceptions list for managing logins exceptions

┆Issue is synchronized with this Jira Task

@liuche liuche changed the title Add exceptions list for logins a user chooses "Don't Save" Don't prompt user to login if they select "Never Save" in password prompt Dec 11, 2019
@liuche
Copy link
Contributor Author

liuche commented Dec 11, 2019

Hey @AmyYLee bringing this up from chatting with MattN, that on Desktop, there's a difference between "Don't save" and "Never save", specifically in how that gets saved in exceptions.

Since we're taking this out of the MVP, we have some more time to think about this. If you have some ideas about this, please let us know - but we probably should get some priority on this so we can prioritize the UX work.

Screen Shot 2019-12-11 at 2 07 58 PM

@liuche
Copy link
Contributor Author

liuche commented Dec 17, 2019

This will require some UX, because we don't distinguish between the user intending "don't save password this time" vs "never save this password and don't prompt me again" @AmyYLee

@AmyYLee
Copy link
Collaborator

AmyYLee commented Dec 18, 2019

Hi @liuche, we should have "Never save" as the option here instead of "Don't save". The assumption is that if the user doesn't want to save a password that they want it to stay that way and not be asked again. If they do change their minds they can remove it from the exceptions list in Settings. This matches Fennec and also in our options for "Save passwords" is either "Always ask" or "Never save".

See below for reference:
Website - Save Login Dialogue@2x

@AmyYLee AmyYLee removed the needs:UX-feedback Needs UX Feedback label Dec 18, 2019
@mnoorenberghe
Copy link

In this design, is there any other way to close the prompt and keep using the webpage without choosing Never Save if I don't want to Save? On desktop, "Never Save" adds website to a list to not save passwords for, it's not specific to the username. If you don't provide the option for a user to not save this specific submission then they won't have the option to save a different username for the site. Of course, you could instead have "Never Save" be specific to the combination of username+website but that's different than desktop.

@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 6, 2020

In this design, is there any other way to close the prompt and keep using the webpage without choosing Never Save if I don't want to Save? On desktop, "Never Save" adds website to a list to not save passwords for, it's not specific to the username. If you don't provide the option for a user to not save this specific submission then they won't have the option to save a different username for the site. Of course, you could instead have "Never Save" be specific to the combination of username+website but that's different than desktop.

@mnoorenberghe if the user taps outside the prompt panel, the prompt disappears without you needing to choose and the prompt will appear again the next time you go to the website.

@lobontiumira
Copy link

The prompt is still displayed after selecting "Don't save".
Tested on the latest Nightly build from 3/24 (#20840606), and on Beta 4.2.0-beta.1 with OnePlus 5T (Android 9).

@vesta0 vesta0 removed the should label Mar 29, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Mar 29, 2020

Also Don't save should be changed to Never save

@liuche
Copy link
Contributor Author

liuche commented Mar 31, 2020

Taking this out because we don't have a "Don't save" yet, for MVP.

@ekager
Copy link
Contributor

ekager commented May 13, 2020

This came up again in some Reddit feedback I was reading. User story was a user used a 3rd party password manager and wasn't an FxA user and did not want to keep being asked for the same website (seemed like they logged into the same sites often maybe an always in private mode user). If we manage the exceptions list storage ourselves (probably in AC), this is actionable now.

@mnoorenberghe
Copy link

This came up again in some Reddit feedback I was reading. User story was a user used a 3rd party password manager and wasn't an FxA user and did not want to keep being asked for the same website (seemed like they logged into the same sites often maybe an always in private mode user). If we manage the exceptions list storage ourselves (probably in AC), this is actionable now.

Does that user save some logins in the Firefox password manager? If not then wouldn't they want the global toggle instead?

@ekager
Copy link
Contributor

ekager commented Jul 1, 2020

The UX was in the original mocks for logins: https://share.goabstract.com/46b9d737-fcde-434f-bc6a-5b23b574fe5e?collectionLayerId=7d248eb9-de9d-4304-8d9c-e2034778f682&mode=design so this is eng ready AFAICT

@ekager ekager added the eng:ready Ready for engineering label Jul 1, 2020
@ekager ekager self-assigned this Jul 1, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 2, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 2, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 6, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 7, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 7, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 13, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 13, 2020
ekager added a commit that referenced this issue Jul 14, 2020
@ekager ekager added the eng:qa:needed QA Needed label Jul 14, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 16, 2020

Hi, verified as fixed on the latest Nightly Build 200716 from 7/16 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

►Video
20200716-153233

@AndiAJ AndiAJ closed this as completed Jul 16, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Logins
Projects
None yet
Development

No branches or pull requests

7 participants