Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Enabling search suggestions #6070

Closed
1 task
vesta0 opened this issue Oct 17, 2019 · 5 comments
Closed
1 task

[Telemetry] Enabling search suggestions #6070

vesta0 opened this issue Oct 17, 2019 · 5 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Search Feature:Telemetry
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 17, 2019

Description & Product Manager / Data Scientist User Story

  • As a product owner, I want to know if users prefer to keep search suggestions disabled in private mode

What questions will you answer with this data?

  • Do users choose to receive search suggestions in private mode (and therefore share their searches with their search provider)? How often do users choose this setting will determine what should be our default.

What probes (suggested, if applicable)

Dependencies

Acceptance Criteria (Added by PM)

  • Event pings can be queried via re:dash
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry
  • NOT an AC: Data science to create dashboard or further graphs (this will be a separate issue, this issue is only about hooking up the events described and that they can be queried in re-dash)

Comment 0 changes

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the E3 Estimation Point: average, 2 - 3 days label Oct 22, 2019
@severinrudie severinrudie self-assigned this Nov 11, 2019
@severinrudie severinrudie added this to the v3.1 milestone Nov 11, 2019
@severinrudie severinrudie added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Nov 11, 2019
@severinrudie
Copy link
Contributor

This is waiting on #1019, which will add the UI element that requires telemetry.

@severinrudie severinrudie removed their assignment Nov 11, 2019
@mcarare mcarare self-assigned this Nov 19, 2019
@mcarare
Copy link
Contributor

mcarare commented Nov 19, 2019

@vesta0 Just to clarify: we only want to track events of enabling search suggestions in private from the hint panel (UI prompt)? That is a unique event.
Or we also want to track enabling from the settings screen? This could be a repeating event for the same user. TY!

@mcarare
Copy link
Contributor

mcarare commented Nov 20, 2019

@liuche can you please help me with this info? Thank you!

@liuche
Copy link
Contributor

liuche commented Nov 20, 2019

@vesta0 Just to clarify: we only want to track events of enabling search suggestions in private from the hint panel (UI prompt)? That is a unique event.

Yes, what users choose for this hint.

Or we also want to track enabling from the settings screen? This could be a repeating event for the same user. TY!

Yes, we'd like to track this toggle event, and this setting should also be included in the baseline ping. See #975 (comment)

@mcarare mcarare removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 22, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 27, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 27, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 27, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 28, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 28, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 28, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 28, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Dec 2, 2019
@liuche liuche added the eng:qa:needed QA Needed label Dec 5, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 6, 2019

Hi, verified as fixed on both Fenix Nightly Build #13391806 from 12/5 and Beta 3.0.0-beta.3 Build #13392157 from 12/5 using a Google Pixel 3a (Android 9)

► Beta
✔️ Choose "Allow" from hint - Ping 3f02c223-f241-4542-9d05-cbd3d071d9e5
✔️ State when opening Search Settings (updated and displayed properly) - Ping fcdab8a9-4b25-4264-990d-c54d693908e2
Toggle events:
✔️OFF - Ping 8be36d6c-3edf-4593-8936-74475b476f74
✔️ON - Ping be2b9cba-5dad-4354-b51e-acd3757fb80e

Logcat
Glean dashboard

► Nightly
✔️ Choose "Allow" from hint - Ping 22095256-fbec-4bcd-8768-4e3f86f1dd02
✔️ State when opening Search Settings (updated and displayed properly) - Ping 969c94c1-ff7e-494d-9322-ba3e5812fbd3
Toggle events:
✔️ OFF - Ping 9f6f49ee-ebe0-442d-a1c1-0fa0a5d97f58
✔️ ON - Ping d91bf209-637b-4028-a498-93d87299007c
Logcat
Glean dashboard

@liuche - Shouldn't we also track the "Don't allow" event from the hint ?
Or we track it only when disabling it from the Search Settings?

@AndiAJ AndiAJ closed this as completed Dec 6, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 6, 2019
@liuche liuche modified the milestones: v3.1, v3.0 Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Search Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

5 participants