Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] wrong header bar background color for libraries screen #7584

Closed
cadeyrn opened this issue Jan 9, 2020 · 6 comments · Fixed by #13767 or #13967
Closed

[Bug] wrong header bar background color for libraries screen #7584

cadeyrn opened this issue Jan 9, 2020 · 6 comments · Fixed by #13767 or #13967
Labels
🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Jan 9, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open Settings > About Firefox Preview > Libraries that we use

Expected behavior

The header bar has the same background color as every other screen in Firefox Preview (white).

Actual behavior

The header bar is black.

Screenshot_20200109-233559

Device information

  • Android device: OnePlus 7T Pro McLaren Edition / Android 10
  • Fenix version: master branch revision 0a412a1

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Jan 9, 2020
@mcarare
Copy link
Contributor

mcarare commented Jan 13, 2020

This has another issue, i.e., the OssLicensesActivity also changes the colour for navigation and status bar. The more direct approach is to create a custom fragment for this, instead of relying on the system one. The work for this was supposed to be done in AC.

@mcarare mcarare added the needs:ac Needs Android Component Work label Jan 13, 2020
@darkwing
Copy link
Contributor

@mcarare Is there an AC issue open for this? Could your provide a link?

@mcarare
Copy link
Contributor

mcarare commented Feb 11, 2020

@darkwing I am not aware of any issue already opened in AC.

@cadeyrn cadeyrn mentioned this issue Aug 13, 2020
Merged
4 tasks
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 13, 2020
@gilbsgilbs
For mozilla-mobile#162 - use a FLOSS library to display licenses info
c528c1c 
While Google's oss-licenses gradle plugin that collects the gradle
dependencies is free, the library that ships with the APK is not. This
commit replace the library and plugin with a popular free one:
AboutLibraries.

Fixes mozilla-mobile#7584
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 14, 2020
@gilbsgilbs
Add custom Activity to show libraries licenses.
1937a0a 
As Google's library for showing licences isn't open-source, this commit
reimplements its main Activity. This is in prevision to having an OSS
flavor of fenix.

We chose to not introduce dependencies to third-party libraries
such as AboutLibraries for now, and we'll stick to using Google's gradle
plugin for the dependencies extraction.

Fixes mozilla-mobile#7584

See also mozilla-mobile#162
liuche pushed a commit that referenced this issue Aug 18, 2020
@gilbsgilbs @liuche
Add custom Activity to show libraries licenses.
2743c37 
As Google's library for showing licences isn't open-source, this commit
reimplements its main Activity. This is in prevision to having an OSS
flavor of fenix.

We chose to not introduce dependencies to third-party libraries
such as AboutLibraries for now, and we'll stick to using Google's gradle
plugin for the dependencies extraction.

Fixes #7584

See also #162
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Aug 19, 2020

@liuche Can you re-open the issue? I just checked this. The color of the header bar is no longer black but it's still the wrong color. I am not sure if the new color of the header bar is used anywhere else in Fenix, the color does not look familiar to me.

@liuche
Copy link
Contributor

liuche commented Aug 19, 2020

That's definitely weird! @gilbsgilbs is that something that you had fixed in your PR?

@liuche liuche reopened this Aug 19, 2020
@gilbsgilbs
Copy link
Contributor

My PR fixed the light toolbar in dark mode (see screenshots), but I didn't notice it wasn't the exact same color as the rest of the app. It's probably because the screen is a different activity which uses the global theme.

gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 20, 2020
@gilbsgilbs
for mozilla-mobile#7584 - about libraries toolbar theme
02c782d
@gilbsgilbs gilbsgilbs mentioned this issue Aug 20, 2020
Merged
4 tasks
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 20, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
f6c520e 
fixes mozilla-mobile#7584 mozilla-mobile#13970
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 20, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
4c2c760 
fixes mozilla-mobile#7584 mozilla-mobile#13970
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 20, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
d6841b9 
fixes mozilla-mobile#7584 mozilla-mobile#13970
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 21, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
c60a725 
fixes mozilla-mobile#7584 mozilla-mobile#13970
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 21, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
ffff7da 
fixes mozilla-mobile#7584 mozilla-mobile#13970
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 21, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
1c1c85d 
fixes mozilla-mobile#7584 mozilla-mobile#13970
@liuche liuche mentioned this issue Aug 21, 2020
Closed
4 tasks
gilbsgilbs added a commit to gilbsgilbs/fenix that referenced this issue Aug 22, 2020
@gilbsgilbs
for mozilla-mobile#7584 - fix about libraries toolbar theme
c012f06 
fixes mozilla-mobile#7584 mozilla-mobile#13970
@liuche liuche mentioned this issue Aug 24, 2020
Closed
4 tasks
liuche pushed a commit that referenced this issue Aug 24, 2020
@gilbsgilbs @liuche
for #7584 - fix about libraries toolbar theme
9430546 
fixes #7584 #13970
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work
Projects
None yet
Milestone
No milestone
5 participants
@darkwing @liuche @cadeyrn @gilbsgilbs @mcarare