Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fennec migration: Migration onboarding UI dismissed if you minimize the app #7980

Closed
sv-ohorvath opened this issue Jan 17, 2020 · 4 comments
Closed

Fennec migration: Migration onboarding UI dismissed if you minimize the app #7980

sv-ohorvath opened this issue Jan 17, 2020 · 4 comments
Assignees
@pocmo @Sparky93
Labels
🐞 bug Crashes, Something isn't working, ..

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jan 17, 2020 •
edited by data-sync-user
Loading

STR:

  1. Install the Fenix migration build over Fennec. Open the updating app.
  2. Wait for the "migration complete" screen, with the Start browsing button.
  3. Minimize the app by pressing the home button, don't close the app entirely.
  4. Tap the home screen launcher to return to the app. Or, from recent apps, tap the second instance of the app, that doesn't show the migration onboarding screen.

Expected results:
The migration complete onboarding screen is still shown.

Actual results:
The migration onboarding is dismissed when you return to the app and the Fenix onboarding screen is displayed. (the home launcher is opening the second instance of the app, that didn't have the migration screen on it)

Note: if you select from the recent apps the instance that has a snapshot with the migration onboarding, it will show the migration onboarding screen.

Build: Nightly Migration build#2
Devices: HTC 10 (Android 8), Samsung S8 (Android 9)

┆Issue is synchronized with this Jira Task
@vesta0
Copy link
Collaborator

vesta0 commented Jan 20, 2020

This is not a blocker.

@Sparky93
Copy link
Contributor

Hello guys, I'd like to help on this issue.

@Mugurell Mugurell assigned Mugurell and Sparky93 and unassigned Mugurell Jan 23, 2020
@Mugurell Mugurell transferred this issue from mozilla-mobile/android-components Jan 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 29, 2020
@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. and removed needs:triage Issue needs triage labels Jan 29, 2020
Sparky93 added a commit to Sparky93/fenix that referenced this issue Jan 29, 2020
@Sparky93
Fix for mozilla-mobile#7980 - MigrationStore's COMPLETE action now re…
78a234b 
…directs to MigrationProgressActivity

In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
Sparky93 added a commit to Sparky93/fenix that referenced this issue Feb 4, 2020
@Sparky93
Fix for mozilla-mobile#7980 - MigrationStore's COMPLETE action now re…
e7b0bf6 
…directs to MigrationProgressActivity

In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
pocmo pushed a commit to Sparky93/fenix that referenced this issue Feb 11, 2020
@Sparky93 @pocmo
Fix for mozilla-mobile#7980 - MigrationStore's COMPLETE action now re…
81e92cd 
…directs to MigrationProgressActivity

In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
@pocmo pocmo self-assigned this Feb 11, 2020
pocmo pushed a commit that referenced this issue Feb 11, 2020
@Sparky93 @pocmo
Fix for #7980 - MigrationStore's COMPLETE action now redirects to Mig…
1ed185d 
…rationProgressActivity

In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
@pocmo
Copy link
Contributor

pocmo commented Feb 11, 2020

Landed and should be available in the next build.

@pocmo pocmo closed this as completed Feb 11, 2020
@abodea
Copy link
Member

abodea commented Feb 14, 2020

Verified as fixed on Migration Build #9 (Build #2015722947) 2/14 using a Samsung Galaxy S8+(Android 8).
Note that the Migration onboarding UI was not dismissed after minimizing the app, I tried at least 10 times.
Based on my comment I will move this issue to the Done column.

@ebalazs-sv ebalazs-sv mentioned this issue Jun 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@Sparky93 Sparky93

Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pocmo @sv-ohorvath @Mugurell @Sparky93 @vesta0 @abodea