Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Toolbar styling changes to private style for normal tabs after entering private browsing mode #811

Closed
yoasif opened this issue Mar 2, 2019 · 6 comments
Closed

Toolbar styling changes to private style for normal tabs after entering private browsing mode #811

yoasif opened this issue Mar 2, 2019 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen Feature:PrivateBrowsing needs:investigation P1 Current sprint
Milestone
Bugs and Polish

Comments

@yoasif
Copy link
Contributor

yoasif commented Mar 2, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open page
  2. Tap tab switcher icon
  3. Tap Private browsing mask
  4. Tap "back"

Expected behavior

Toolbar should be white.

Actual behavior

Toolbar is purplish.

Device information

  • Android device: Pixel 2
  • Fenix version: 1.0.1909 (Build #10601903 🦎 67.0a1-20190227104426)

┆Issue is synchronized with this Jira Task
@ekager ekager added the 🐞 bug Crashes, Something isn't working, .. label Mar 4, 2019
@ekager ekager self-assigned this Mar 5, 2019
@ekager ekager added this to the Sprint 3-1 (Milestone 3) milestone Mar 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Mar 5, 2019
@ekager
Closes mozilla-mobile#811 - Clear stack after switching to private br…
60a17df 
…owsing
@ghost ghost added in progress labels Mar 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Mar 5, 2019
@ekager
Closes mozilla-mobile#811 - Clear stack after switching to private br…
c090c3c 
…owsing
@ekager ekager closed this as completed in 8b793cd Mar 5, 2019
@ghost ghost removed in progress labels Mar 5, 2019
ekager added a commit that referenced this issue Mar 6, 2019
@ekager
Revert "Closes #811 - Clear stack after switching to private browsing"
d48cd82 
This reverts commit 8b793cd.
@ekager ekager mentioned this issue Mar 6, 2019
Merged
sblatz pushed a commit that referenced this issue Mar 6, 2019
@ekager @sblatz
Revert "Closes #811 - Clear stack after switching to private browsing" (
58b32e9 
#876)

This reverts commit 8b793cd.
@ekager ekager reopened this Mar 7, 2019
@ekager ekager removed their assignment Mar 13, 2019
@ekager
Copy link
Contributor

ekager commented Mar 13, 2019

Related to #1012, this is partly because we maintain the entire backstack and partly because we set the theme for the whole app when switching to private browsing

@vesta0 vesta0 modified the milestones: Sprint 3-2 (Milestone 3), Bugs Mar 14, 2019
@ekager ekager mentioned this issue Mar 14, 2019
Closed
@ekager ekager closed this as completed Mar 14, 2019
@sv-ohorvath
Copy link
Contributor

Still reproducing on Nightly 3/14 build.
devices: Nexus 5 (Android 6), Samsung S8 (Android 9)

@sv-ohorvath sv-ohorvath reopened this Mar 15, 2019
@vesta0 vesta0 removed this from the MVP Bugs milestone Mar 18, 2019
@callahad
Copy link

callahad commented Mar 23, 2019 •
edited
Loading

Another path that surfaces this bug, while browsing:

  • Menu → Private Tab → Back

Subsequently hitting the tab switcher takes you to the Private Mode overview, with no tabs, instead of the normal mode overview which has the current tab.

@sblatz
Copy link
Contributor

sblatz commented Mar 25, 2019

@vesta0 I believe this should be an "MVP Bug" considering it gives the user an incorrect understanding of whether or not they're in private mode.

@vesta0 vesta0 added this to the MVP Backlog milestone Apr 1, 2019
@vesta0 vesta0 added the P1 Current sprint label Apr 1, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, Bugs Apr 1, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 2, 2019

UX working on a related bug #1012

@ekager
Copy link
Contributor

ekager commented May 2, 2019

This is no longer an issue

@ekager ekager closed this as completed May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen Feature:PrivateBrowsing needs:investigation P1 Current sprint
Projects
None yet
Milestone
Bugs and Polish
Development

No branches or pull requests
7 participants
@callahad @yoasif @kbrosnan @sv-ohorvath @sblatz @ekager @vesta0