Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fennec migration: The steps from the onboarding migration screen have the wrong text size, font and spacing #8422

Closed
ebalazs-sv opened this issue Feb 12, 2020 · 8 comments · Fixed by #9945
Closed

Fennec migration: The steps from the onboarding migration screen have the wrong text size, font and spacing #8422

ebalazs-sv opened this issue Feb 12, 2020 · 8 comments · Fixed by #9945
Assignees
@jonalmeida
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Migration

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Feb 12, 2020 •
edited by data-sync-user
Loading

Preconditions:

Have Fennec installed.

Steps to reproduce

  1. Replace Fennec with Fenix with a build from https://github.com/mozilla-mobile/fenix/wiki/Fennec-Migration;
  2. Launch Fenix;
  3. Observe the steps from the onboarding migration screen.

Expected behavior

The steps are displayed like in the specs.

Actual behavior

The space between the steps is too small, also the text size and font is wrong.

Notes:

Video
This is also reproducible on Nightly migration build 02/10.

Device information

  • Android device: OnePlus 5T (Android 9), Nexus 6P (Android 8.1.0), Huawei Honor 8 (Android 7.0);
  • Fenix version: Beta migration build 02/12

┆Issue is synchronized with this Jira Task
@Sparky93 Sparky93 self-assigned this Feb 13, 2020
@Sparky93 Sparky93 transferred this issue from mozilla-mobile/android-components Feb 14, 2020
@Sparky93 Sparky93 added 🐞 bug Crashes, Something isn't working, .. Feature:Migration labels Feb 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 14, 2020
@Sparky93 Sparky93 removed the needs:triage Issue needs triage label Feb 14, 2020
@ebalazs-sv
Copy link
Author

This is also reproducible on Nightly Migration Build 9, 02/14.

Sparky93 added a commit to Sparky93/fenix that referenced this issue Feb 14, 2020
@Sparky93
Fix for mozilla-mobile#8422 - Migration steps displayed in a differen…
433a8a0 
…t order than UI specifications

Changed the order of the whitelisted migrations in order to respect the UI specifications.

Now using linked hash map instead of hash map for the whitelisted migrations so we can preserve the
order of the steps upon status changing in the migration process.
@Sparky93
Copy link
Contributor

As said in #7955 and as per Bram's comment, this is going to be fixed in #3687 and #8089.

@ebalazs-sv ebalazs-sv mentioned this issue Feb 17, 2020
Closed
@apbitner
Copy link

Those related tickets may fix the font family being used, but there are still issues with the spacing and layout of the page. Please see the spec in the issue details above.

@ebalazs-sv
Copy link
Author

This is reproducible on Beta Migration Build #3 with Huawei P9 Lite (Android 7), Google Pixel 3 (Android 10).

@ebalazs-sv
Copy link
Author

ebalazs-sv commented Mar 25, 2020 •
edited
Loading

This is still reproducible on Beta Migration build 75.0.0-beta.1, from 3/24, with Huawei P9 Lite (Android 7).

@ebalazs-sv
Copy link
Author

Since this is still reproducible I will move it from Ready for QA to Beta.

@jonalmeida jonalmeida assigned jonalmeida and unassigned Sparky93 Mar 31, 2020
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 15, 2020
@jonalmeida
For mozilla-mobile#8422: Add spacing between migration items
1fdb34a
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 15, 2020
@jonalmeida
For mozilla-mobile#8422: Add misc migration UI fixes
2bc0fa3
@jonalmeida jonalmeida linked a pull request Apr 15, 2020 that will close this issue
For #8422: Add misc migration UI fixes #9945
Merged
2 tasks
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 15, 2020
@jonalmeida
For mozilla-mobile#8422: Add spacing between migration items
4155d7c
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 15, 2020
@jonalmeida
For mozilla-mobile#8422: Add misc migration UI fixes
28e38f2
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 16, 2020
@jonalmeida
For mozilla-mobile#8422: Add misc migration UI fixes
215b89f
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 16, 2020
@jonalmeida
For mozilla-mobile#8422: Add misc migration UI fixes
b75e5de
ekager pushed a commit that referenced this issue Apr 16, 2020
@jonalmeida @ekager
For #8422: Add spacing between migration items
25d5b0d
ekager pushed a commit that referenced this issue Apr 16, 2020
@jonalmeida @ekager
For #8422: Add misc migration UI fixes
2bb1b6e
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 16, 2020
@jonalmeida
For mozilla-mobile#8422: Add more misc migration UI fixes
080f417
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 17, 2020
@jonalmeida
For mozilla-mobile#8422: Add more misc migration UI fixes
65c2c70
jonalmeida added a commit that referenced this issue Apr 17, 2020
@jonalmeida
For #8422: Add more misc migration UI fixes
cab0bfc
@jonalmeida jonalmeida reopened this Apr 24, 2020
@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Apr 24, 2020
@jonalmeida
Copy link
Contributor

This can be verified with on a nightly migration.

@ebalazs-sv
Copy link
Author

Verified as fixed on the latest Nightly Migration build 200427 (Build #2015736947) with Pixel 2 (Android 9), Nexus 5 (Android 6.0.1), Samsung Galaxy Tab S3 (Android 8).
I will remove the qa:needed label and close this issue. Thanks!

@ebalazs-sv ebalazs-sv removed the eng:qa:needed QA Needed label Apr 27, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Crashes, Something isn't working, .. Feature:Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #8422: Add misc migration UI fixes jonalmeida/fenix
4 participants
@jonalmeida @Sparky93 @apbitner @ebalazs-sv