-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature/#6557 Organic search telemetry #10167
Feature/#6557 Organic search telemetry #10167
Conversation
8978595
to
c0f9f6b
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
c0f9f6b
to
2fcb2c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like a little more detail in the documentation before finishing data review.
Still needs code review from someone.
in_content: | ||
type: labeled_counter | ||
description: > | ||
Records the type of interaction a user has on SERP pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include the types of data that this could be, or provide an example? That way, if someone from data science is looking at our documentation, they have a very clear idea of what kind of data this looks like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR was merged already, I'll add a new task with the docs change
@@ -0,0 +1,32 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: License?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSONs don't allow standard comments. Looked over in AC and none of the extension manifest files have license added, so I think we have to make exceptions for these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
Instructions: Data Stewards will review a request for data collection and endorse responses to each question.
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, with metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, in the Fenix settings -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry, Fenix team will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
All data is category 2. -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry. Fenix team will monitor -
Does the data collection use a third-party collection tool?
No
Pull Request checklist
After merge
To download an APK when reviewing a PR: