-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #10465: Add telemetry for voice search #10785
Conversation
94919b6
to
c464b54
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 09/01/2020
|
c464b54
to
27573fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #10785 +/- ##
============================================
- Coverage 19.17% 19.16% -0.01%
Complexity 600 600
============================================
Files 360 360
Lines 14845 14850 +5
Branches 2014 2015 +1
============================================
Hits 2846 2846
- Misses 11739 11744 +5
Partials 260 260
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending addressing comments (mainly the documentation one)
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, included in metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Expires in 6mo
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
no
- Is the data collection covered by the existing Firefox privacy notice?
yes
- Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry
- Does the data collection use a third-party collection tool?
no
@@ -137,6 +137,7 @@ events: | |||
show_search_shortcuts, open_links_in_a_private_tab (bug in | |||
implementation https://github.com/mozilla-mobile/fenix/issues/7384), | |||
pref_key_sync_logins, pref_key_sync_bookmarks, pref_key_sync_history, | |||
pref_key_show_voice_search, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sblatz, do you think these pref states should be moved to the metrics ping? These are different, someone actively toggling a pref vs what the value of the pref is - do we care how often a pref is toggled, versus how many people have it enabled/disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear. My understanding was that @vesta0 wanted to know when users went in to settings to disable it.
@vesta0 would you prefer this be sent in the baseline ping? e.g. "user has voice search disabled, has open links in private tab enabled, etc.)?
I agree this seems more useful but I think we also wanted to know if people were aware they could even change these settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, let's merge this as is for now. Sounds like there may be some more clean up data science and I need to do on these to get better data from them, but that's a larger project!
@@ -137,6 +137,7 @@ events: | |||
show_search_shortcuts, open_links_in_a_private_tab (bug in | |||
implementation https://github.com/mozilla-mobile/fenix/issues/7384), | |||
pref_key_sync_logins, pref_key_sync_bookmarks, pref_key_sync_history, | |||
pref_key_show_voice_search, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not get updated in the metrics.md? I don't see a change in that file included in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I just need to do a rebuild of the project to generate. Let's see what Vesta responds to the other comment :)
27573fb
to
8f77ce8
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: