-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixes #9832 - Change targetSdkVersion to Android 10 #11014
Conversation
0ee30b7
to
2443a94
Compare
Codecov Report
@@ Coverage Diff @@
## master #11014 +/- ##
=============================================
- Coverage 22.12% 8.82% -13.31%
+ Complexity 725 245 -480
=============================================
Files 377 373 -4
Lines 15098 15040 -58
Branches 1957 2032 +75
=============================================
- Hits 3341 1327 -2014
- Misses 11469 13619 +2150
+ Partials 288 94 -194 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now that we've cut a release.
private fun showPinVerification() { | ||
val manager = activity?.getSystemService(KEYGUARD_SERVICE) as KeyguardManager | ||
val manager = activity?.getSystemService<KeyguardManager>()!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should use un-safe calls if the newer target SDK asserts them as nullable. Some devices maybe not support some system services and we shouldn't crash because of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're already using unsafe calls as we cast nullable to not-null. The SDK doesn't assert if a system service is null or not, the extension method simply always returns a nullable type.
@@ -16,7 +17,7 @@ private const val MIME_TYPE_TEXT_HTML = "text/html" | |||
* A clipboard utility class that allows copying and pasting links/text to & from the clipboard | |||
*/ | |||
class ClipboardHandler(context: Context) { | |||
private val clipboard = context.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager | |||
private val clipboard = context.getSystemService<ClipboardManager>()!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the previous comment.
No major changes to upgrade now!
Pull Request checklist
After merge
To download an APK when reviewing a PR: