Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8920 - [Telemetry] Send add-on ids in a metrics ping #11080

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

gabrielluong
Copy link
Member

Fixes #8920.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #11080 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11080      +/-   ##
============================================
- Coverage     20.46%   20.45%   -0.01%     
  Complexity      680      680              
============================================
  Files           372      372              
  Lines         15442    15447       +5     
  Branches       2081     2082       +1     
============================================
  Hits           3160     3160              
- Misses        11986    11991       +5     
  Partials        296      296              
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 8.67% <0.00%> (-0.03%) 3.00 <0.00> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 20.05% <0.00%> (-0.25%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e74e3...80e9962. Read the comment docs.

@gabrielluong
Copy link
Member Author

gabrielluong commented May 30, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How many user have a specific add-on installed and enabled, over a specific time period
  • How often users interact with an installed add-on (in the toolbar menu) to look up or modify settings? This will help us learn whether we should collaborate with the add-on developer to invest in improving settings/UI for individual add-ons.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us prioritize bugs and features related to WebExtensions based on user need.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • No current alternative methods.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 09/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@gabrielluong gabrielluong force-pushed the 8920 branch 2 times, most recently from 8aa4012 to 5810f63 Compare May 30, 2020 07:00
@gabrielluong gabrielluong requested review from boek and liuche May 30, 2020 07:02
@gabrielluong gabrielluong marked this pull request as ready for review May 30, 2020 07:02
@gabrielluong gabrielluong added the needs:data-review PR is awaiting a data review label May 30, 2020
@gabrielluong gabrielluong force-pushed the 8920 branch 3 times, most recently from 2683ebc to 24bb379 Compare June 2, 2020 23:33
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documented usage in metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, custom pings are controlled by the Fenix data settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Expires in 9/2020

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2, measuring addon usage.

  2. Is the data collection request for default-on or default-off?

default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, has expiry

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] Send add-on ids in separate ping
3 participants