This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #12201 - forced sync layout callbacks to be on the main thread #12543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account manager from AC works similar to the store that we have (so it has states and a reducer), however it delivers the result to consumers via old-school observer pattern, and since the reducer is on a different thread, all consumers are notified on that thread as well.
This consumer needs to perform UI changes, so it's required to be on main thread for that to happen. I chose to set only this consumer on the main thread and not switch context in the account manager reducer, because some consumers do computation and should remain on the separate thread.
Pull Request checklist
After merge
To download an APK when reviewing a PR: