This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
force-pushed
the
test-sync-wifi-push
branch
from
July 15, 2020 18:35
7fc67f1
to
0bac0f4
Compare
ekager
approved these changes
Jul 15, 2020
NotWoods
force-pushed
the
test-sync-wifi-push
branch
from
July 16, 2020 01:07
0bac0f4
to
47a90f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #12581 +/- ##
============================================
+ Coverage 25.15% 25.54% +0.39%
- Complexity 845 866 +21
============================================
Files 389 389
Lines 15700 15687 -13
Branches 2022 2020 -2
============================================
+ Hits 3949 4008 +59
+ Misses 11444 11371 -73
- Partials 307 308 +1
Continue to review full report at Codecov.
|
jonalmeida
reviewed
Jul 16, 2020
@@ -159,7 +159,10 @@ class BackgroundServices( | |||
notificationManager.showReceivedTabs(context, device, tabs) | |||
} | |||
|
|||
SyncedTabsIntegration(context, accountManager).launch() | |||
SyncedTabsIntegration( | |||
syncedTabsStorage = syncedTabsStorage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't land this without testing the feature carefully. If I recall correctly, this causes a cyclic dependency, which is why we accessed the storage via the context instead of passing it in through he constructor.
NotWoods
force-pushed
the
test-sync-wifi-push
branch
from
July 16, 2020 16:47
47a90f3
to
0cc825d
Compare
NotWoods
force-pushed
the
test-sync-wifi-push
branch
from
July 16, 2020 18:38
0cc825d
to
729ff2e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to lots of tests, there has been some cleanup: