This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #162 - add feature build flag to disable firebase push service #13857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
Closed
gilbsgilbs
force-pushed
the
build-flags-firebase
branch
4 times, most recently
from
65ec94d to
cc9eb0b
Compare
This allows to specify flags at build time that will allow to enable/disable specific features from fenix. The first use-case for this is to produce a variant of fenix without proprietary components such as gms. For instance, passing the "-Porg.mozilla.fenix.enableFeatureXYZ=false" will disable the XYZ feature from the build.
gilbsgilbs
force-pushed
the
build-flags-firebase
branch
from
cc9eb0b to
7a98a3d
Compare
gilbsgilbs
force-pushed
the
build-flags-firebase
branch
from
7a98a3d to
8739ffa
Compare
|
@gilbsgilbs Is this waiting for code review? |
|
@opusforlife2 Yes, but I won't be able to re-work on it very soon. If someone wants to pickup with this work, I can give write access to my repo or they can open their own PR. |
|
Could you leave a comment in the F-Droid issue saying you're busy, then? Maybe someone will read it and pick up where you've left off. |
20 tasks
|
Hi @gilbsgilbs, thank you for your contribution! Since #162 seems to be resolved now (it's a long discussion that I am not fully caught up with), I am closing this PR for the now to clean up our PR backlog. We can always reopen this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
This PR introduces a build flag that allows to enable/disable firebase push service. To build fenix without the firebase push service, just run:
Or add the following line to your
$GRADLE_HOME/gradle.propertiesto make the config persistent:Pull Request checklist
After merge
To download an APK when reviewing a PR: