-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #14565: Add telemetry for top sites #15136
For #14565: Add telemetry for top sites #15136
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
To measure how useful the different types of top sites are to users. It will help us prioritize top sites features, and help us understand if the carousel for top sites is understood by users or if we should reconsider that UX.
This data will be present collected until it expires as outlined in the
|
859d142
to
8191cf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #15136 +/- ##
============================================
- Coverage 29.22% 29.22% -0.01%
- Complexity 1161 1164 +3
============================================
Files 454 454
Lines 18541 18563 +22
Branches 2393 2397 +4
============================================
+ Hits 5419 5425 +6
- Misses 12745 12762 +17
+ Partials 377 376 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, fenix telemetry settings
- If the request is for permanent data collection, is there someone who will monitor the data over time?
No has expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, interaction with top sites and the carousel
- Is the data collection request for default-on or default-off?
default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, interaction with UI elements
- Is the data collection covered by the existing Firefox privacy notice?
yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
No, has expiry
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
8191cf2
to
8839bd1
Compare
8839bd1
to
05f48de
Compare
Pull Request checklist
To download an APK when reviewing a PR: