Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #14866: Telemetry for Open Saved Data in New Tab #16626

Closed
wants to merge 2 commits into from

Conversation

kglazko
Copy link
Contributor

@kglazko kglazko commented Nov 18, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@kglazko
Copy link
Contributor Author

kglazko commented Nov 18, 2020

@eliserichards @ekager I am stuck in that I'm not sure how to add the Telemetry counter events for opening a history, bookmark, or sync tab to the AwesomeBarView.kt. It looks like AwesomeBarView just takes all of these options and consolidates them into a map of providers. There's a check for tapping on search terms or URL but I don't know if it's possible to check whether or not you can tap on an a specific type of provider (i.e. History or Bookmarks or Sync) from AwesomeBar.

@gabrielluong gabrielluong added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Nov 18, 2020
@ekager
Copy link
Contributor

ekager commented Nov 18, 2020

Hi! I would have to look at exactly which telemetry we are looking to add, but it's possible you might need to emit facts for these in AC in the corresponding Suggestion Providers for example for bookmarks in the BookmarkStorageSuggestionProvider onSuggestionClicked lambda?

@kglazko
Copy link
Contributor Author

kglazko commented Nov 20, 2020

Thank you, Emily! Do you think it's possible to have the same Telemetry event for both the actions in Fenix and in AC? (basically, tapping on a bookmark, not the open bookmark menu item) in Library and Suggestions, and same for history. This PR only address the taps in the Library section so far, but the telemetry event should be the same for both Library opens and Suggestions opens..

@eliserichards eliserichards changed the title Telemetry for Open Saved Data in New Tab For #14866: Telemetry for Open Saved Data in New Tab Jan 13, 2021
@gabrielluong
Copy link
Member

Closing this since this is done according to #14866.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants