-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
d59532d
to
f5758ce
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 03/01/2020
|
7ef5856
to
302a30e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, metrics.yaml -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix has data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?**
Has expiry, fenix-core@ will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, and any custom search engines will be sent ascustom
-
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry -
Does the data collection use a third-party collection tool?
No
source: | ||
description: > | ||
A string that tells us how the user performed the search. Possible values are: | ||
* default.action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're not collecting the search engine name here, does Glean have things like histograms? That seems like it might be more suited to this (but up to you).
302a30e
to
0ccc7cc
Compare
Pull Request checklist