Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11580 - Tracks text selection context menu usage #16968

Conversation

codrut-topliceanu
Copy link
Contributor

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

For #11580
Needs to be landed AFTER: mozilla-mobile/android-components#9185

Pull Request checklist

  • Tests: This PR does not include any tests as it is only a minor change.
  • Screenshots: This PR has no user visible changes.
  • Accessibility: The code in this PR does not include any user facing features.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codrut-topliceanu
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?

  • What percentage of users tab on any of the long press context menu options (copy, share, search, select all)?
  • Which context menu options are used most frequently.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
Measure whether this feature is used by users and how often.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
This is the only way.

4) Can current instrumentation answer these questions?
No. We need a new specific event for a specific app feature.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Usage text selection context menu taps Category 2 https://github.com//issues/11580

6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
This collection is documented in the metrics.md document document included in the project - https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md

7) How long will this data be collected? Choose one of the following:
Until 2021-06-01.

8) What populations will you measure?
All release channels and locales.

9) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Data collection.

10) Please provide a general description of how you will analyze this data.
Glean / Amplitude

11) Where do you intend to share the results of your analysis?
Only on Glean, Amplitude and with mobile teams.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

@codrut-topliceanu codrut-topliceanu marked this pull request as ready for review December 10, 2020 16:27
@codrut-topliceanu codrut-topliceanu requested review from a team as code owners December 10, 2020 16:27
@codrut-topliceanu codrut-topliceanu added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Dec 10, 2020
@codrut-topliceanu codrut-topliceanu force-pushed the 11580_telemetry_text_context_menu branch from 5416a8e to 1df267b Compare December 14, 2020 13:39
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, Fenix data collection settings.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    No, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry

  9. Does the data collection use a third-party collection tool?
    No

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

This pull request has conflicts when rebasing. Could you fix it @codrut-topliceanu? 🙏

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed Feature:Telemetry needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Dec 16, 2020
codrut.topliceanu and others added 2 commits January 4, 2021 15:52
Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.
…ontroller.kt

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@codrut-topliceanu codrut-topliceanu force-pushed the 11580_telemetry_text_context_menu branch from 101d5ee to cdab151 Compare January 4, 2021 13:59
@codrut-topliceanu codrut-topliceanu merged commit c0f0c40 into mozilla-mobile:master Jan 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
…ozilla-mobile#16968)

* For mozilla-mobile#11580 - Tracks text selection context menu usage

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants