Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #974: Telemetry for Bookmarks #1708

Merged
merged 1 commit into from
Apr 17, 2019
Merged

For #974: Telemetry for Bookmarks #1708

merged 1 commit into from
Apr 17, 2019

Conversation

colintheshots
Copy link
Contributor

@colintheshots colintheshots commented Apr 17, 2019 •
edited
Loading

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@colintheshots colintheshots requested a review from a team as a code owner April 17, 2019 17:41
@ghost ghost assigned colintheshots Apr 17, 2019
@ghost ghost added the review label Apr 17, 2019
@colintheshots colintheshots force-pushed the fix974 branch 2 times, most recently from c69b7fd to 6834b64 Compare April 17, 2019 17:45
@colintheshots
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often bookmarks are opened and in what ways
  • Which bookmark management features are users interacting with
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • To measure how useful these features are
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently no, as these are some of the first metrics we're recording
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 04/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@colintheshots colintheshots requested a review from boek April 17, 2019 17:48
colintheshots
colintheshots commented Apr 17, 2019
View reviewed changes
app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt
@@ -108,13 +116,6 @@ class EditBookmarkFragment : Fragment(), CoroutineScope {
updateBookmarkFromObservableInput()
}

override fun onPause() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the code to move bookmarks, as I noticed a occasional race condition by backgrounding it during onPause. If needed, I can separate this fix from the Telemetry PR.

app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt
@@ -84,6 +84,17 @@ class BookmarkFragment : Fragment(), CoroutineScope, BackHandler, AccountObserve
super.onResume()
(activity as AppCompatActivity).supportActionBar?.show()
checkIfSignedIn()

val currentGuid = BookmarkFragmentArgs.fromBundle(arguments!!).currentRoot.ifEmpty { BookmarkRoot.Root.id }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now rechecking bookmarks during every onResume in case they changed on disk.

@colintheshots colintheshots mentioned this pull request Apr 17, 2019
Closed
boek
boek suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close! This is a good reminder for me to document all the telemetry information.

boek
boek approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
    Yes, metrics.yaml

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes through the Fenix data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?**
    Has expiry, fenix-core@ will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
    Has expiry

  9. Does the data collection use a third-party collection tool?
    No

@boek
Copy link
Contributor

boek commented Apr 17, 2019

Code looks good too :shipit:

@boek boek merged commit 849764d into mozilla-mobile:master Apr 17, 2019
@ghost ghost removed the review label Apr 17, 2019
@colintheshots colintheshots deleted the fix974 branch April 18, 2019 03:17
@liuche liuche mentioned this pull request Aug 21, 2020
Merged
4 tasks
@mcarare mcarare mentioned this pull request Feb 24, 2021
Merged
3 tasks
@eliserichards eliserichards mentioned this pull request Jun 14, 2021
Merged
3 tasks
@mdboom mdboom mentioned this pull request Aug 26, 2021
Merged
3 tasks
@eliserichards eliserichards mentioned this pull request Oct 8, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boek boek boek approved these changes

Assignees

@colintheshots colintheshots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colintheshots @boek