Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18617 - Use the new EngineView#getInputResultDetail() #18619

Merged
merged 1 commit into from
Mar 31, 2021
Merged

For #18617 - Use the new EngineView#getInputResultDetail() #18619

merged 1 commit into from
Mar 31, 2021

Conversation

Mugurell
Copy link
Contributor

Migrate to the new api after mozilla-mobile/android-components#9963 will deprecate InputResult.
All functionality should remain the same.

DynamicDownloadDialogBehavior.mp4

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners March 24, 2021 14:45
@Mugurell Mugurell added the pr:needs-ac-bump PR that needs a AC bump label Mar 25, 2021
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AC patch has landed and this LGTM with a rebase. 👍

@Mugurell
Copy link
Contributor Author

The AC patch has landed and this LGTM with a rebase. 👍

Thank you @jonalmeida but I think the AC patch is still in review.
mozilla-mobile/android-components#9963
I have a conflict in changelog there which I'm waiting to fix for after a r+. So it will be easy to sync the merge of this two :-)) - have to take specific actions for both.

@jonalmeida
Copy link
Contributor

Oops, must have looked at the wrong AC issue then. :)

I'll have a look at that PR in that case.

@Mugurell
Copy link
Contributor Author

Mugurell commented Mar 30, 2021

@Mugurell Mugurell closed this Mar 30, 2021
@Mugurell Mugurell reopened this Mar 30, 2021
@Mugurell
Copy link
Contributor Author

I see the same tests failing the second time also:

  • goForwardTest - "No views in hierarchy found matching: with content description text: is "Forward"
  • refreshPageTest - "No views in hierarchy found matching: with content description text: is "Refresh"
  • testPageReloadAfterNetworkInterrupted - AssertionError in "waitNotNull(Until.findObject(By.desc("Refresh"))"
  • mainMenuShareButtonTest - AssertionError in "waitNotNull(Until.findObject(By.desc("Share"))"
  • mainMenuRefreshButtonTest - "No views in hierarchy found matching: with content description text: is "Refresh"
  • ShareButtonAppearanceTest - "No views in hierarchy found matching: with content description text: is "Share"

But in both runs, each test passes once and fails once.
Since they seem unrelated to these changes and just flaky I'll try running them again before disabling.

All functionality should remain the same.
@Mugurell
Copy link
Contributor Author

Thank you @andi for disabling these tests and help unblock this merge.
Didn't think of this because nothing should've changed regarding the menus but looking at the videos from Firebase it seems like for this PR the new menu was used (which doesn't fit the screen and had the options tests needed scrolled off) while for other PRs the old menu is used (with fewer menu items, all available in tests)
Even though a isDebug feature flag is used so I think all PRs should've used the new menu already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-ac-bump PR that needs a AC bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants