-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #18617 - Use the new EngineView#getInputResultDetail() #18619
For #18617 - Use the new EngineView#getInputResultDetail() #18619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AC patch has landed and this LGTM with a rebase. 👍
Thank you @jonalmeida but I think the AC patch is still in review. |
Oops, must have looked at the wrong AC issue then. :) I'll have a look at that PR in that case. |
Seemingly unrelated ui tests failing. |
I see the same tests failing the second time also:
But in both runs, each test passes once and fails once. |
All functionality should remain the same.
Thank you @andi for disabling these tests and help unblock this merge. |
Migrate to the new api after mozilla-mobile/android-components#9963 will deprecate
InputResult
.All functionality should remain the same.
DynamicDownloadDialogBehavior.mp4
Pull Request checklist
To download an APK when reviewing a PR: