Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18375: Add experiment for set default browser New Tab card. #18872

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Apr 8, 2021

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Apr 8, 2021
@mcarare mcarare force-pushed the 18375s branch 7 times, most recently from 7c75981 to 0c89bab Compare April 9, 2021 07:49
@mcarare mcarare closed this Apr 9, 2021
@mcarare mcarare reopened this Apr 9, 2021
@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #18872 (95c15d0) into master (e8d405b) will decrease coverage by 0.04%.
The diff coverage is 10.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18872      +/-   ##
============================================
- Coverage     34.42%   34.37%   -0.05%     
  Complexity     1543     1543              
============================================
  Files           526      527       +1     
  Lines         21427    21461      +34     
  Branches       3203     3206       +3     
============================================
+ Hits           7376     7378       +2     
- Misses        13159    13190      +31     
- Partials        892      893       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/org/mozilla/fenix/experiments/Experiments.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 3.45% <0.00%> (-0.01%) 6.00 <0.00> (ø)
...fenix/home/sessioncontrol/SessionControlAdapter.kt 0.77% <0.00%> (-0.02%) 0.00 <0.00> (ø)
...ix/home/sessioncontrol/SessionControlController.kt 71.79% <0.00%> (-1.51%) 0.00 <0.00> (ø)
...ix/home/sessioncontrol/SessionControlInteractor.kt 62.96% <0.00%> (-5.04%) 17.00 <0.00> (ø)
...la/fenix/home/sessioncontrol/SessionControlView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...boarding/ExperimentDefaultBrowserCardViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/org/mozilla/fenix/home/HomeFragmentStore.kt 81.13% <25.00%> (-6.87%) 1.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 72.67% <30.00%> (-0.85%) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d405b...95c15d0. Read the comment docs.

@mcarare mcarare added needs:review PRs that need to be reviewed and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Apr 9, 2021
@mcarare mcarare marked this pull request as ready for review April 9, 2021 08:30
@mcarare mcarare requested review from a team as code owners April 9, 2021 08:30
@mcarare mcarare force-pushed the 18375s branch 2 times, most recently from 9ec2fc0 to fb91b2e Compare April 9, 2021 11:49
@Amejia481 Amejia481 self-requested a review April 12, 2021 14:48
@mcarare mcarare removed request for a team April 12, 2021 15:20
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, awesome work!

No sure if it's related but the org.mozilla.fenix.ui.HistoryTest.deleteAllHistoryTest UI test is failing.

https://console.firebase.google.com/u/1/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/5171125956912378492/executions/bs.6deed8cbf9b84996/test-cases

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍🏽

@mcarare mcarare merged commit ba218e6 into mozilla-mobile:master Apr 13, 2021
@amedyne amedyne added this to the 89 milestone Apr 19, 2021
@amedyne amedyne removed this from the 89 milestone Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants