This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #18375: Add experiment for set default browser New Tab card. #18872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c75981
to
0c89bab
Compare
Codecov Report
@@ Coverage Diff @@
## master #18872 +/- ##
============================================
- Coverage 34.42% 34.37% -0.05%
Complexity 1543 1543
============================================
Files 526 527 +1
Lines 21427 21461 +34
Branches 3203 3206 +3
============================================
+ Hits 7376 7378 +2
- Misses 13159 13190 +31
- Partials 892 893 +1
Continue to review full report at Codecov.
|
9ec2fc0
to
fb91b2e
Compare
3 tasks
Amejia481
reviewed
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, awesome work!
No sure if it's related but the org.mozilla.fenix.ui.HistoryTest.deleteAllHistoryTest
UI test is failing.
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt
Outdated
Show resolved
Hide resolved
Amejia481
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👍🏽
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
To download an APK when reviewing a PR: