-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Waiting on Data Review] For #1192: Adds telemetry for Mozilla products #1953
Conversation
7328b95
to
b3f0da7
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 04/01/2020 (renewed thereafter)
|
Going to try to get @liuche for data review since I discussed with her a bit and also Jeff is on PTO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I have an action item to double check that collecting other Mozilla browsers is fine, so I will report back if this is a problem.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, in metrics.yaml -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, data controls in Fenix -
If the request is for permanent data collection, is there someone who will monitor the data over time?**
No, will be expired in 9/2019, fenix-core@ will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 2, Mozilla products installed, or set as default -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
I believe so, but have asked to double check. -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry -
Does the data collection use a third-party collection tool?
No
app/metrics.yaml
Outdated
mozilla_products: | ||
type: string_list | ||
description: > | ||
A list of all the Mozilla products installed on device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a pain, but can you include the list here? That way, if someone is looking to make sure that list is "complete" or needs to be updated, it's here in this documentation.
Pull Request checklist