Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Waiting on Data Review] For #1192: Adds telemetry for Mozilla products #1953

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Apr 23, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz requested a review from a team as a code owner April 23, 2019 21:57
@ghost ghost assigned sblatz Apr 23, 2019
@ghost ghost added the review label Apr 23, 2019
@sblatz sblatz force-pushed the mozilla-telem branch 2 times, most recently from 7328b95 to b3f0da7 Compare April 23, 2019 21:58
@sblatz
Copy link
Contributor Author

sblatz commented Apr 23, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • What other Mozilla owned products Fenix users have installed
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • We may want to surface different features to users who have certain Mozilla products installed like Lockbox, for example. It's also useful to know if users of Fenix have a different Mozilla browser set as their default so we can ensure our product is reaching a wide enough audience.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently no, as these are some of the first metrics we're recording
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 04/01/2020 (renewed thereafter)

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek April 23, 2019 21:59
@sblatz sblatz requested a review from liuche April 24, 2019 15:12
@sblatz
Copy link
Contributor Author

sblatz commented Apr 24, 2019

Going to try to get @liuche for data review since I discussed with her a bit and also Jeff is on PTO.

@sblatz sblatz removed the request for review from boek April 24, 2019 16:04
@sblatz sblatz changed the title For #1192: Adds telemetry for Mozilla products [Waiting on Data Review] For #1192: Adds telemetry for Mozilla products Apr 24, 2019
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I have an action item to double check that collecting other Mozilla browsers is fine, so I will report back if this is a problem.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
    Yes, in metrics.yaml

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, data controls in Fenix

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?**
    No, will be expired in 9/2019, fenix-core@ will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
    Type 2, Mozilla products installed, or set as default

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    I believe so, but have asked to double check.

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry

  9. Does the data collection use a third-party collection tool?
    No

app/metrics.yaml Outdated
mozilla_products:
type: string_list
description: >
A list of all the Mozilla products installed on device
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a pain, but can you include the list here? That way, if someone is looking to make sure that list is "complete" or needs to be updated, it's here in this documentation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants