Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Issue #19846: Make sure default browser notification only happens once #20373

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger added the needs:review PRs that need to be reviewed label Jul 14, 2021
@rocketsroger rocketsroger requested review from a team as code owners July 14, 2021 22:29
@jonalmeida jonalmeida added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jul 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #20373 (8c2976b) into master (317cbe9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20373      +/-   ##
============================================
- Coverage     36.07%   36.07%   -0.01%     
  Complexity     1564     1564              
============================================
  Files           538      538              
  Lines         20994    20994              
  Branches       3140     3140              
============================================
- Hits           7574     7573       -1     
- Misses        12573    12574       +1     
  Partials        847      847              
Impacted Files Coverage Δ
...fenix/home/intent/DefaultBrowserIntentProcessor.kt 100.00% <ø> (ø)
...nix/onboarding/DefaultBrowserNotificationWorker.kt 1.92% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317cbe9...8c2976b. Read the comment docs.

@mergify mergify bot merged commit 68b56ff into mozilla-mobile:master Jul 15, 2021
@rocketsroger rocketsroger deleted the FB_19846 branch July 15, 2021 02:23
@rocketsroger
Copy link
Contributor Author

@Mergifyio backport releases_v91.0.0

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2021

Command backport releases_v91.0.0: success

Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants