Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20996: Telemetry renewals for september and october #21076

Merged
merged 20 commits into from
Aug 31, 2021

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Aug 30, 2021

For #20996

Doc [waiting for approval from Vesta]: https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit#

Needs:

  • product review (see doc)
  • data review
  • include data review link in renewed metrics
  • eng review

Probes to renew

  • progressive_web_app: homescreen_tap, install_tap, foreground, background
  • android_keystore_experiment: experiment_failure, get_failure, get_result, write_failure, write_success, reset:
  • default_browser_changed
  • toolbar_menu_visible
  • experiments_default_browser: toolbar_menu_clicked
  • startup_type
  • home_menu: settings_item_clicked
  • home_screen: home_screen_displayed
  • set_default_newtab_experiment: set_default_browser_clicked, close_experiment_card_clicked
  • set_default_setting_experiment: set_default_browser_clicked

Probes to delete

We let the majority of these probes expire already. These commits are just to remove the dead probes.

  • master_password (commit): displayed, migration
  • download_notification (commit): .resume, .pause, .cancel, .try_again, .open, .in_app_open, .in_app_try_again
  • downloads_misc(commit): .download_added
  • downloads_management:(commit): .downloads_screen_opened, .item_opened, .item_deleted
  • about_page(commit): support_tapped, .privacy_notice_tapped
  • total_uri_count(commit)
  • find_in_page(commit): opened, closed, searched_page
  • open_links_in_private(commit)
  • private_search_suggestions(commit)
  • tip(commit): displayed, pressed, closed
  • private_browsing_mode(commit): snackbar_undo, notification_tapped
  • private_browsing_mode(commit): snackbar_undo, notification_tapped
  • private_browsing_shortcut(commit): create_shortcut, cfr_add_shortcut, cfr_cancel, pinned_shortcut_priv. static_shortcut_tab, static_shortcut_priv
  • user_specified_search_engines(commit): custom_engine_added, custom_engine_deleted
  • search_suggestions(commit): enable_in_private
  • banner_open_in_app(commit): displayed, dismissed, go_to_settings

Probes to let expire

N/A

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards
Copy link
Author

eliserichards commented Aug 30, 2021

Request for Data Collection Renewal

progressive_web_app: homescreen_tap, install_tap, foreground, background

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in September 2021 will now expire on March 1, 2022 (2022-03-01). See doc for breakdown of individual probes and expiration dates.
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor this data through the MR2 release.

android_keystore_experiment: experiment_failure, get_failure, get_result, write_failure, write_success, reset:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in September 2021 will now expire on March 1, 2022 (2022-03-01).
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor this data through the MR2 release.

default_browser_changed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor this data through the MR2 release to help track engagement.

toolbar_menu_visible:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • This will be important for our work post-MR2 and we want to continue collecting data so we have a comparison.

experiments_default_browser: toolbar_menu_clicked:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor data from our experiments through the MR2 release.

startup_type

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • Continues to be used to monitor performance.

home_menu: settings_item_clicked

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • This will be important for our work post-MR2 and we want to continue collecting data so we have a comparison.

home_screen: home_screen_displayed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • This is important data for the MR2 release.

set_default_newtab_experiment: set_default_browser_clicked, close_experiment_card_clicked:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor data from our experiments through the MR2 release.

set_default_setting_experiment: set_default_browser_clicked:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).
  3. Why was the initial period of collection insufficient?

    • We are continuing to monitor data from our experiments through the MR2 release.

@eliserichards eliserichards added the needs:data-review PR is awaiting a data review label Aug 30, 2021
@eliserichards eliserichards requested a review from travis79 August 30, 2021 22:10
@eliserichards eliserichards linked an issue Aug 30, 2021 that may be closed by this pull request
@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Aug 30, 2021
@travis79
Copy link
Member

Request for Data Collection Renewal

progressive_web_app: homescreen_tap, install_tap, foreground, background

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10261: PWA Telemetry #11859](https://github.com/mozilla-mobile/fenix/pull/11859)

2. When will this collection now expire?
   
   * All probes that were set to expire in September 2021 will now expire on March 1, 2022 (2022-03-01). See [doc](https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit) for breakdown of individual probes and expiration dates.

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor this data through the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

android_keystore_experiment: experiment_failure, get_failure, get_result, write_failure, write_success, reset:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Android keystore experiment #18333 (review)](https://github.com/mozilla-mobile/fenix/pull/18333#pullrequestreview-612447395)

2. When will this collection now expire?
   
   * All probes that were set to expire in September 2021 will now expire on March 1, 2022 (2022-03-01).

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor this data through the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

default_browser_changed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Telemetry for #18855, #18851 and #18857  #18982 (review)](https://github.com/mozilla-mobile/fenix/pull/18982#pullrequestreview-635098629)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor this data through the MR2 release to help track engagement.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

toolbar_menu_visible:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Telemetry for #18855, #18851 and #18857  #18982 (review)](https://github.com/mozilla-mobile/fenix/pull/18982#pullrequestreview-635098629)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * This will be important for our work post-MR2 and we want to continue collecting data so we have a comparison.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

experiments_default_browser: toolbar_menu_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Telemetry for #18855, #18851 and #18857  #18982 (review)](https://github.com/mozilla-mobile/fenix/pull/18982#pullrequestreview-635098629)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor data from our experiments through the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

startup_type

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18836: add telemetry for start up type #19028](https://github.com/mozilla-mobile/fenix/pull/19028)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * Continues to be used to monitor performance.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

home_menu: settings_item_clicked

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18856: Add metrics for opening settings screen from home menu. #18987](https://github.com/mozilla-mobile/fenix/pull/18987)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * This will be important for our work post-MR2 and we want to continue collecting data so we have a comparison.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

home_screen: home_screen_displayed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18854: Add metrics for home screen being displayed. #19025](https://github.com/mozilla-mobile/fenix/pull/19025)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * This is important data for the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

set_default_newtab_experiment: set_default_browser_clicked, close_experiment_card_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18853: Add metrics for default browser new tab experiment. #18895](https://github.com/mozilla-mobile/fenix/pull/18895)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor data from our experiments through the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

set_default_setting_experiment: set_default_browser_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18852: Add metrics for default browser settings screen experiment. #19047](https://github.com/mozilla-mobile/fenix/pull/19047)

2. When will this collection now expire?
   
   * All probes that were set to expire in October 2021 will now expire on April 1, 2022 (2022-04-01).

3. Why was the initial period of collection insufficient?
   
   * We are continuing to monitor data from our experiments through the MR2 release.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@eliserichards don't forget to update the data-reviews in the metrics.yaml to add this comment to the list, thanks!

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Aug 31, 2021
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this!

@rocketsroger rocketsroger removed the needs:review PRs that need to be reviewed label Aug 31, 2021
@eliserichards eliserichards force-pushed the 20996-telemetry-sept-oct branch from 0e8145d to 932217b Compare August 31, 2021 16:26
@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Aug 31, 2021
@eliserichards eliserichards force-pushed the 20996-telemetry-sept-oct branch from 5c5bd8a to 12a2cb4 Compare August 31, 2021 16:34
@eliserichards eliserichards added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 31, 2021
@mergify mergify bot merged commit 13fd069 into mozilla-mobile:main Aug 31, 2021
@eliserichards
Copy link
Author

@Mergifyio backport releases_v92.0.0

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Command backport releases_v92.0.0: success

Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry renewals for Sept/Oct
3 participants