-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #21313: Renewing performance awesomebar metrics #21315
For #21313: Renewing performance awesomebar metrics #21315
Conversation
Request for Data Collection Renewal
|
Tagging you for data review @travis79 😄 |
Probably have time tomorrow or Friday, if later than that I'll see if someone else can get to it sooner. Thanks! |
Data Collection Renewal Review
Yes
Yes Resultdata-reveiw+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-review+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @eliserichards !
app/metrics.yaml
Outdated
@@ -4102,13 +4102,14 @@ perf.awesomebar: | |||
data_reviews: | |||
- https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 | |||
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 | |||
- https://github.com/mozilla-mobile/fenix/pull/TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check-in the updated |
Add data review link to renewed metrics
c93d922
to
3f8c35e
Compare
The |
Flaky test, the same one I'm seeing in this PR
|
@Mergifyio rebase |
Command
|
More tests failing:
|
For #21313
Needs data review before landing
Renewing the following metrics:
perf.awesomebar
:Pull Request checklist
To download an APK when reviewing a PR: