Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #21623 - Pocket recommended stories telemetry #21625

Merged
merged 2 commits into from
Oct 7, 2021
Merged

For #21623 - Pocket recommended stories telemetry #21625

merged 2 commits into from
Oct 7, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Oct 1, 2021

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners October 1, 2021 10:19
@Mugurell Mugurell changed the title For #21593 - Pocket recommended stories telemetry For #21623 - Pocket recommended stories telemetry Oct 1, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will help us understand how the new Pocket recommended stories feature is used.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This data will help us understand which features in the home screen are more important for users.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
An indication of when the Pocket recommended stories are shown Category 2 - interaction data #21623
An indication of when the user clicks a certain story Category 2 - interaction data #21623
An indication for how many times the clicked story was shown Category 2 - interaction data #21623
An indication for the position of the clicked story in list Category 2 - interaction data #21623
An indication of when the user clicks a certain category Category 2 - interaction data #21623
An indication for the clicked category's name Category 2 - interaction data #21623
An indication for the number of selected category when one is clicked Category 2 - interaction data #21623
An indication for the new state that the clicked category will transition to Category 2 - interaction data #21623
An indication of when the "Discover more" link is clicked Category 2 - interaction data #21623
An indication of when the "Learn more" link is clicked Category 2 - interaction data #21623
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • One year (ending on October 1st, 2022), with the option to renew at that point.

  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • 
Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amejia481 Amejia481 added the needs:data-review PR is awaiting a data review label Oct 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2021

This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏

@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 4, 2021

@travis79 Wondering if your might be a good data reviewer for this :-).

@travis79
Copy link
Member

travis79 commented Oct 4, 2021

@travis79 Wondering if your might be a good data reviewer for this :-).

I should have time to data-review this either this afternoon or tomorrow morning 👍

@travis79
Copy link
Member

travis79 commented Oct 6, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This data will help us understand how the new Pocket recommended stories feature is used.


1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This data will help us understand which features in the home screen are more important for users.


1. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


1. Can current instrumentation answer these questions?


* No.


1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
An indication of when the Pocket recommended stories are shown Category 2 - interaction data #21623
An indication of when the user clicks a certain story Category 2 - interaction data #21623
An indication for how many times the clicked story was shown Category 2 - interaction data #21623
An indication for the position of the clicked story in list Category 2 - interaction data #21623
An indication of when the user clicks a certain category Category 2 - interaction data #21623
An indication for the clicked category's name Category 2 - interaction data #21623
An indication for the number of selected category when one is clicked Category 2 - interaction data #21623
An indication for the new state that the clicked category will transition to Category 2 - interaction data #21623
An indication of when the "Discover more" link is clicked Category 2 - interaction data #21623
An indication of when the "Learn more" link is clicked Category 2 - interaction data #21623

1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [dictionary.telemetry.mozilla.org/apps/fenix](https://dictionary.telemetry.mozilla.org/apps/fenix)


1. How long will this data be collected? Choose one of the following:


* One year (ending on October 1st, 2022), with the option to renew at that point.


1. What populations will you measure?


* All channels, all locales, all countries


1. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


1. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


1. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the standard telemetry preference in the application setttings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection to end or be renewed by 2022-10-1

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Oct 6, 2021
@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 7, 2021
@mergify mergify bot merged commit 507801e into mozilla-mobile:main Oct 7, 2021
@Mugurell Mugurell deleted the pockeTelemetry branch October 7, 2021 08:37
@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 7, 2021

Waiting for QA to validate before uplifting.

@Mugurell
Copy link
Contributor Author

@Mergifyio backport releases_v94.0.0

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

backport releases_v94.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants