Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Fix flaky UI tests caused by AmbiguousViewMatcherException and other refactoring work #21704

Merged
merged 6 commits into from
Oct 8, 2021

Conversation

AndiAJ
Copy link
Collaborator

@AndiAJ AndiAJ commented Oct 5, 2021

• Fix flaky tests caused by AmbiguousViewMatcherException
Both me and @sv-ohorvath ran the affected tests 150x on Firebase and successfully passed.

• Removed closeTabViaXButton() and replace it with closeTab() in the UI tests (have the same applicability)
• Removed openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests (have the same applicability)

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@AndiAJ AndiAJ force-pushed the ambiguous_tab_item branch 3 times, most recently from 45dc4c7 to 74cf9d7 Compare October 5, 2021 13:44
@AndiAJ AndiAJ closed this Oct 5, 2021
@AndiAJ AndiAJ reopened this Oct 5, 2021
@AndiAJ AndiAJ force-pushed the ambiguous_tab_item branch 3 times, most recently from 9ab5762 to 0c219ee Compare October 6, 2021 04:49
@AndiAJ AndiAJ force-pushed the ambiguous_tab_item branch from 0c219ee to 0981468 Compare October 8, 2021 09:12
@AndiAJ AndiAJ self-assigned this Oct 8, 2021
@AndiAJ AndiAJ added the eng:ui-test UI Tests label Oct 8, 2021
@AndiAJ AndiAJ marked this pull request as ready for review October 8, 2021 09:35
@AndiAJ AndiAJ requested review from a team as code owners October 8, 2021 09:35
@AndiAJ AndiAJ requested review from isabelrios and AaronMT October 8, 2021 09:35
@AndiAJ AndiAJ changed the title Potential fix for shareTabsFromTabsTrayTest & verifyOpenTabDetails Fix flaky UI tests caused by AmbiguousViewMatcherException and other refactoring work Oct 8, 2021
Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks for the investigation and fix

@AndiAJ AndiAJ added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Oct 8, 2021
@AndiAJ AndiAJ closed this Oct 8, 2021
@AndiAJ AndiAJ reopened this Oct 8, 2021
@AndiAJ AndiAJ added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 8, 2021
@mergify mergify bot merged commit 2eae152 into mozilla-mobile:main Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:ui-test UI Tests pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants