Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #21313: Renew fission metrics expiring in December #21779

Merged

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Oct 7, 2021

For #21313

  • Approval from @agi - see doc
  • data review
  • update data review TBDs in PR

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners October 7, 2021 18:54
@eliserichards
Copy link
Author

Request for Data Collection Renewal

engine_tab:

  • kills
  • kill_foreground_age
  • kill_background_age 
  • foreground_metrics
  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in December 2021 will now expire in July 2022 (2022-07-01).
  3. Why was the initial period of collection insufficient?

    • These metrics are being actively used to monitor the Fission project, which is still ongoing.

@eliserichards eliserichards added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Oct 7, 2021
@eliserichards eliserichards linked an issue Oct 7, 2021 that may be closed by this pull request
@travis79
Copy link
Member

travis79 commented Oct 7, 2021

Request for Data Collection Renewal

engine_tab:

* `kills`

* `kill_foreground_age`

* `kill_background_age`

* `foreground_metrics`


1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #12731: Collect telemetry about the content process of tabs getting killed. #17864](https://github.com/mozilla-mobile/fenix/pull/17864)

2. When will this collection now expire?
   
   * All probes that were set to expire in December 2021 will now expire in July 2022 (2022-07-01).

3. Why was the initial period of collection insufficient?
   
   * These metrics are being actively used to monitor the Fission project, which is still ongoing.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Oct 7, 2021
@eliserichards eliserichards force-pushed the 21313-renew-fission-metrics branch from 737ebdc to ce84bbb Compare October 7, 2021 19:35
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eliserichards
Copy link
Author

Weird taskcluster error for build-android-test-debug:

fatal: The remote end hung up unexpectedly
[vcs 2021-10-07T19:39:07.601Z] fatal: early EOF
[vcs 2021-10-07T19:39:07.602Z] fatal: index-pack failed
[taskcluster 2021-10-07 19:39:07.879Z] === Task Finished ===

@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Oct 7, 2021
@eliserichards
Copy link
Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2021

Command rebase: success

Branch has been successfully rebased

@eliserichards eliserichards force-pushed the 21313-renew-fission-metrics branch from ce84bbb to 5ef6348 Compare October 7, 2021 22:32
@eliserichards
Copy link
Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2021

Command rebase: success

Branch already up to date

@eliserichards
Copy link
Author

This test is failing consistently:

  • DefaultPocketStoriesControllerTest: GIVEN a category is selected WHEN that same category is clicked THEN deselect it and record telemetry

@eliserichards eliserichards force-pushed the 21313-renew-fission-metrics branch from 5ef6348 to 6092df8 Compare October 8, 2021 22:47
@eliserichards eliserichards removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 9, 2021
@eliserichards eliserichards reopened this Oct 9, 2021
@eliserichards eliserichards force-pushed the 21313-renew-fission-metrics branch from 2773fba to 78d5df8 Compare October 9, 2021 00:26
@eliserichards eliserichards added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 9, 2021
@mergify mergify bot merged commit 7e12bd3 into mozilla-mobile:main Oct 9, 2021
@eliserichards
Copy link
Author

@Mergifyio backport releases_v94.0.0

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2021

Command backport releases_v94.0.0: success

Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] Renew/delete probes for Nov/Dec
3 participants