Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #21313: Remove expiring/unused metrics for December #21789

Merged
merged 5 commits into from
Nov 4, 2021
Merged

For #21313: Remove expiring/unused metrics for December #21789

merged 5 commits into from
Nov 4, 2021

Conversation

eliserichards
Copy link

For #21313

Removing the following metrics:

  • crash_reporter: opened, closed
  • tab_counter_menu_action
  • ...

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards mentioned this pull request Oct 7, 2021
Merged
6 tasks
@eliserichards eliserichards force-pushed the 21313-remove-expired-metrics branch from 1bccc5b to a1193de Compare October 8, 2021 22:57
@eliserichards eliserichards marked this pull request as ready for review November 2, 2021 23:46
@eliserichards eliserichards requested review from a team as code owners November 2, 2021 23:46
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@eliserichards eliserichards changed the title [WIP] For #21313: Remove expiring/unused metrics for December For #21313: Remove expiring/unused metrics for December Nov 2, 2021
@eliserichards eliserichards force-pushed the 21313-remove-expired-metrics branch from a1193de to 6876c46 Compare November 2, 2021 23:49
@eliserichards eliserichards linked an issue Nov 2, 2021 that may be closed by this pull request
[Telemetry] Renew/delete probes for Nov/Dec #21313
Closed
@eliserichards
Copy link
Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

rebase

✅ Branch has been successfully rebased

@eliserichards eliserichards force-pushed the 21313-remove-expired-metrics branch from 6876c46 to 8ecf008 Compare November 3, 2021 01:58
@eliserichards
Copy link
Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

rebase

✅ Branch has been successfully rebased

@eliserichards eliserichards force-pushed the 21313-remove-expired-metrics branch from 8ecf008 to 61d4fef Compare November 3, 2021 19:11
@eliserichards eliserichards added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Nov 3, 2021
@mergify mergify bot merged commit 4f55f16 into mozilla-mobile:main Nov 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Mar 7, 2022
@mergify @pkirakosyan
For mozilla-mobile#21313: Remove expiring/unused metrics for December (…
a98d45c 
…mozilla-mobile#21789)

* Remove crash reporter metrics

* Remove tab counter menu item probe

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees
No one assigned
Labels
pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Telemetry] Renew/delete probes for Nov/Dec
2 participants
@eliserichards @rocketsroger