Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Close #22172: Add Recent searches telemetry #22173

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Sorry, something went wrong.

@rocketsroger rocketsroger added the needs:review PRs that need to be reviewed label Oct 26, 2021
@rocketsroger rocketsroger requested review from a team as code owners October 26, 2021 19:08
@rocketsroger
Copy link
Contributor Author

rocketsroger commented Oct 26, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will help us understand is user uses recent searches.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us understand if recent searches feature is useful to the user.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
Recent searches tapped: Recent searches on home was tapped by the user. This includes the carousel page number of the card. Category 2 - interaction data #22172
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • One year (ending on November 1st, 2022), with the option to renew at that point.

  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • 
Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@rocketsroger rocketsroger added the needs:data-review PR is awaiting a data review label Oct 26, 2021
*/
class HistoryMetadataGroupViewHolder(
val composeView: ComposeView,
private val store: HomeFragmentStore,
private val interactor: HistoryMetadataInteractor
private val interactor: HistoryMetadataInteractor,
val metrics: MetricController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this be private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. Good catch. Thanks,

Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger force-pushed the FB_22172 branch 2 times, most recently from c64faf7 to 7f8c89a Compare October 28, 2021 13:56
@eliserichards
Copy link

eliserichards commented Nov 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will help us understand is user uses recent searches.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us understand if recent searches feature is useful to the user.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
Recent searches tapped: Recent searches on home was tapped by the user. This includes the carousel page number of the card. Category 2 - interaction data #22172
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • One year (ending on November 1st, 2022), with the option to renew at that point.

  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • 
Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

  2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

    • Yes, through the "Send Usage Data" preference in the application settings
  3. If the request is for permanent data collection, is there someone who will monitor the data over time?

    • No, the data will be renewed or removed by November 1, 2022.
  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

    • Category 2 - interaction data
  5. Is the data collection request for default-on or default-off?

    • Default-on
  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

  • No
  1. Is the data collection covered by the existing Firefox privacy notice?

    • Yes
  2. Does the data collection use a third-party collection tool?

    • No

Result

data-review+

@eliserichards eliserichards removed the needs:data-review PR is awaiting a data review label Nov 1, 2021
app/metrics.yaml Outdated
extra_keys:
page_number:
description: |
The page number was the recent searches card on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The page number was the recent searches card on.
The page in the homescreen carousel that the recent searches card is on.

WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll update. Thanks,

@rocketsroger rocketsroger removed the needs:review PRs that need to be reviewed label Nov 1, 2021
@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 2, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify mergify bot merged commit 4e5c9a3 into mozilla-mobile:main Nov 2, 2021
@rocketsroger rocketsroger deleted the FB_22172 branch November 2, 2021 04:17
@rocketsroger
Copy link
Contributor Author

@Mergifyio backport releases_v94.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

backport releases_v94.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MR2 telemetry: Recent searches (prev. recently visited)
3 participants