-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Close #22172: Add Recent searches telemetry #22173
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
9b98b2a
to
463fc4c
Compare
*/ | ||
class HistoryMetadataGroupViewHolder( | ||
val composeView: ComposeView, | ||
private val store: HomeFragmentStore, | ||
private val interactor: HistoryMetadataInteractor | ||
private val interactor: HistoryMetadataInteractor, | ||
val metrics: MetricController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this be private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should. Good catch. Thanks,
463fc4c
to
7f09f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
c64faf7
to
7f8c89a
Compare
Data Review Form (to be filled by Data Stewards)
Resultdata-review+ |
app/metrics.yaml
Outdated
extra_keys: | ||
page_number: | ||
description: | | ||
The page number was the recent searches card on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page number was the recent searches card on. | |
The page in the homescreen carousel that the recent searches card is on. |
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll update. Thanks,
7f8c89a
to
8283ced
Compare
8283ced
to
8ec3183
Compare
@Mergifyio backport releases_v94.0.0 |
✅ Backports have been created
|
Pull Request checklist
To download an APK when reviewing a PR: