Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #22138 - Install source metrics probe #22224

Merged
merged 2 commits into from
Nov 2, 2021
Merged

For #22138 - Install source metrics probe #22224

merged 2 commits into from
Nov 2, 2021

Conversation

Mugurell
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners October 29, 2021 09:54
@Mugurell
Copy link
Contributor Author

Request for data collection review

  1. What questions will you answer with this data?
  • Determine from where the app was installed.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

  • Business related decisions.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?

  • N/A
  1. Can current instrumentation answer these questions?

  • No
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
Measurement Description Data Collection Category Tracking Bug #
String: Package name of the installer for this app Category 1 “Technical data” #22138
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:

  • For now the probes are set to expire in 2022-02-01
  1. What populations will you measure?

  • All users on all release channels
  1. If this data collection is default on, what is the opt-out mechanism for users?

  • Default Glean SDK opt-out mechanism.
  1. Please provide a general description of how you will analyze this data.

  • Redash / GLAM
  1. Where do you intend to share the results of your analysis?

  • Internal with mobile team(s)
  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No

@Mugurell Mugurell added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Oct 29, 2021
@mcarare mcarare removed the needs:review PRs that need to be reviewed label Oct 29, 2021
@rocketsroger
Copy link
Contributor

Request for data collection review

1. What questions will you answer with this data?


* Determine from where the app was installed.


1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* Business related decisions.


1. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* N/A


1. Can current instrumentation answer these questions?


* No


1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Description Data Collection Category Tracking Bug #
String: Package name of the installer for this app Category 1 “Technical data” #22138

1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* https://dictionary.telemetry.mozilla.org/apps/fenix


1. How long will this data be collected? Choose one of the following:


* For now the probes are set to expire in 2022-02-01


1. What populations will you measure?


* All users on all release channels


1. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


1. Please provide a general description of how you will analyze this data.


* Redash / GLAM


1. Where do you intend to share the results of your analysis?


* Internal with mobile team(s)


1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end or be renewed by 2022-02-01

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger rocketsroger removed the needs:data-review PR is awaiting a data review label Nov 1, 2021
@Mugurell Mugurell added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Nov 2, 2021
@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 2, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Nov 2, 2021

TEST: show with no listener nor action failing.
Seemingly unrelated.
Restarting CI.

@Mugurell Mugurell closed this Nov 2, 2021
@Mugurell Mugurell reopened this Nov 2, 2021
@mergify mergify bot merged commit 018fe15 into mozilla-mobile:main Nov 2, 2021
@Mugurell Mugurell deleted the installSource branch November 2, 2021 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants