-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Recent bookmark count telemetry #22293
Recent bookmark count telemetry #22293
Conversation
- interaction | ||
notification_emails: | ||
- android-probes@mozilla.com | ||
expires: "2022-11-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just unsure what to make the expiration date now that the telemetry work for MR2 has rolled over into November.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@@ -823,6 +823,10 @@ private val Event.wrapper: EventWrapper<*>? | |||
{ RecentBookmarks.shown.record(it) } | |||
) | |||
|
|||
is Event.RecentBookmarkCount -> EventWrapper<NoExtraKeys>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, quantity seems to be a good fit here.
Data Review
Yes, through the metrics.yaml file and the Glean Dictionary
Yes, through the "Send Usage Data" preference in the application settings
N/A, collection set to end or be renewed by 2022-11-01
Category 2, Interaction data
default-on
No
Yes
No Resultdata-review+ |
@Mergifyio backport releases_v95.0.0 |
✅ Backports have been created
|
@Mergifyio backport releases_v94.0.0 |
✅ Backports have been created
|
* For mozilla-mobile#22075 - Added event to track the count of recent bookmarks * For mozilla-mobile#22075 - Added data review issue number Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
#22075
Pull Request checklist
To download an APK when reviewing a PR: