This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #21659: Add SERPs to history search groups #22296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
changed the title
grigoryk
approved these changes
Nov 3, 2021
csadilek
added
the
pr:needs-landing
|
This keeps running into #22256. One more try but then we should set that UI test to ignore until we have a fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds SERPs to history search groups (in addition to the result pages opened from SERPs). The diff looks worse because it contains cleanup of our comments to make the cases clearer :).