Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #22577: Update work manager version to 2.7.1 #23080

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jan 6, 2022

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
    No UI changes.
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.
    No UI changes

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare requested a review from Amejia481 January 6, 2022 14:45
@mcarare mcarare added the needs:review PRs that need to be reviewed label Jan 6, 2022
@mcarare mcarare marked this pull request as ready for review January 6, 2022 14:45
@mcarare mcarare requested review from a team as code owners January 6, 2022 14:45
@mcarare mcarare removed request for a team January 6, 2022 14:45
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'd suggest to wait merging until we have the new nightly version to have enough time to discover any unexpected behaviors.

@mcarare mcarare added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jan 7, 2022
@mcarare
Copy link
Contributor Author

mcarare commented Jan 7, 2022

Landing this, as the changelog for leak canary suggests the newer versions leverage the new work manager versions. So it would be easier to est the new behavior changes in #23082.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants