Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Renew/remove metrics set to expire in April 2022 #23786

Merged
merged 1 commit into from
Feb 16, 2022
Merged

No issue: Renew/remove metrics set to expire in April 2022 #23786

merged 1 commit into from
Feb 16, 2022

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Feb 16, 2022
@rocketsroger rocketsroger requested review from a team as code owners February 16, 2022 21:34
@rocketsroger
Copy link
Contributor Author

Request for Data Collection Renewal

Renew for 1 year

Total: 4
———
experiments_default_browser.toolbar_menu_clicked:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • default browser is a key metric

———
home_menu.settings_item_clicked:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • primary user interaction

———
home_screen.home_screen_displayed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • primary user interaction

———
recent_searches.group_deleted:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • working on iterating on the feature

———

@rocketsroger rocketsroger force-pushed the april_2022_telemetry_renewal branch from 4571311 to 1bba479 Compare February 16, 2022 21:37
MozillaNoah
MozillaNoah approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engineering r+

@rocketsroger rocketsroger reopened this Feb 16, 2022
@eliserichards
Copy link

eliserichards commented Feb 16, 2022 •
edited
Loading

Data Collection Renewal Review

Request for Data Collection Renewal

Renew for 1 year

Total: 4 ——— experiments_default_browser.toolbar_menu_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Telemetry for #18855, #18851 and #18857  #18982 (review)](https://github.com/mozilla-mobile/fenix/pull/18982#pullrequestreview-635098629)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * default browser is a key metric
  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

——— home_menu.settings_item_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18856: Add metrics for opening settings screen from home menu. #18987](https://github.com/mozilla-mobile/fenix/pull/18987)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * primary user interaction

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

——— home_screen.home_screen_displayed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #18854: Add metrics for home screen being displayed. #19025](https://github.com/mozilla-mobile/fenix/pull/19025)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * primary user interaction

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

——— recent_searches.group_deleted:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #22175: Telemetry for deleting a search term group from recent searches on home #22176 (comment)](https://github.com/mozilla-mobile/fenix/pull/22176#issuecomment-956421788)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * working on iterating on the feature

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

eliserichards
eliserichards approved these changes Feb 16, 2022
View reviewed changes
Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-review+

@eliserichards eliserichards removed the needs:data-review PR is awaiting a data review label Feb 16, 2022
@rocketsroger rocketsroger merged commit 20094cd into mozilla-mobile:main Feb 16, 2022
@rocketsroger rocketsroger deleted the april_2022_telemetry_renewal branch February 16, 2022 23:34
@rocketsroger
Copy link
Contributor Author

@Mergifyio backport releases_v99.0.0

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

backport releases_v99.0.0

❌ No backport have been created

  • Backport to branch releases_v99.0.0 failed: Branch not found

@rocketsroger
Copy link
Contributor Author

@Mergifyio backport releases_v98.0.0

mergify bot pushed a commit that referenced this pull request Feb 17, 2022
@rocketsroger
No issue: Renew/remove metrics set to expire in April 2022 (#23786)
ef13b7d 
(cherry picked from commit 20094cd)
@mergify mergify bot mentioned this pull request Feb 17, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

backport releases_v98.0.0

✅ Backports have been created

rocketsroger added a commit that referenced this pull request Feb 17, 2022
@mergify @rocketsroger
No issue: Renew/remove metrics set to expire in April 2022 (#23786) (#…
7f47e63 
…23806)

(cherry picked from commit 20094cd)

Co-authored-by: Roger Yang <royang@mozilla.com>
This was referenced May 10, 2022
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards approved these changes

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees
No one assigned
Labels
needs:review PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rocketsroger @eliserichards @MozillaNoah