Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Renew/remove metrics set to expire in v101 #24409

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger
Copy link
Contributor Author

Request for Data Collection Renewal

Renew for 1 year

Total: 1
———
events.tab_view_changed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 113
  3. Why was the initial period of collection insufficient?

    • Keep in case we want to decide to only have the column tabs implementation or other changes to our tab view

———

@rocketsroger rocketsroger added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Mar 23, 2022
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engineering r+

@rocketsroger rocketsroger removed the needs:review PRs that need to be reviewed label Mar 24, 2022
@eliserichards
Copy link

Request for Data Collection Renewal

Renew for 1 year

Total: 1 ——— events.tab_view_changed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #19956: Add telemetry for tab view setting changes #19959 (comment)](https://github.com/mozilla-mobile/fenix/pull/19959#issuecomment-882539619)

2. When will this collection now expire?
   
   * 113

3. Why was the initial period of collection insufficient?
   
   * Keep in case we want to decide to only have the column tabs implementation or other changes to our tab view

———

Data Collection Renewal Review (to be filled by Data Stewards)

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

    • Yes
  2. Is the data collection covered by the existing Firefox Privacy Notice?

    • Yes

Result

data-review+

@eliserichards eliserichards removed the needs:data-review PR is awaiting a data review label Mar 28, 2022
@eliserichards eliserichards self-requested a review March 28, 2022 16:01
Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-review+

@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Mar 29, 2022
@mergify mergify bot merged commit 26767a7 into mozilla-mobile:main Mar 29, 2022
@rocketsroger rocketsroger deleted the 101_expiry branch March 29, 2022 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants