-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #26190 - Update jump back in cfr logic and message #26203
Conversation
a875c5b
to
f92c905
Compare
@@ -22,8 +22,9 @@ | |||
android:layout_marginTop="16dp" | |||
android:layout_marginEnd="8dp" | |||
android:layout_marginBottom="16dp" | |||
android:maxWidth="200dp" | |||
android:text="@string/onboarding_home_screen_jump_back_contextual_hint" | |||
android:maxWidth="279dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this number derived from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the maxWidth
and maxHeight
values, my intention was to respect the Figma values.
Here are a couple of screenshots:
Current | After |
---|---|
![]() |
![]() |
Should we stick with the maxWidth = 200dp
and wrap_content
height instead? We could also file a ticket to use the compose CFR to achieve this behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the height, I'd normally lean towards wrap_content
so text can expand on small devices or devices with larger fonts without being cut-off.
For the width, I'd double check with UX to see if this is supposed to be a fixed width or wrap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @Kate-Galetski to check whether the CFR should respect the design's width (see After
picture in the previous comment) or the current CFR width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Alexandru2909 the width looks fine to me! (atm we don't have any strict rules to how much % of the page the CFR should expand to.) What doesn't look fine to me is that this CFR is glued to the left border of the screen, while it actually should have a padding of 12px in there. Link to figma
@gabrielluong do we need a separate ticket for that adjustment as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am accepting these values since Kate has ok'd them. However, I would ask that you test this with a different language (say German) to see if we need any further followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with multiple languages and the CFR looks fine, apart from the rtl languages, as they use the end
padding and make the CFR look glued to the left edge of the screen. For this I added the 12dp
padding to the end too.
Please test the CFR to see how it looks like with a different language (ex, German) prior to landing. |
This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏 |
Updated message and logic for jump back in onboarding message.
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #26190