Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #26870: remove layer behind wallpaper thumbnails #26871

Conversation

MatthewTighe
Copy link
Contributor

@MatthewTighe MatthewTighe commented Sep 7, 2022

Excellent fake wallpaper thumbnails included 😎

Note that https://github.com/mozilla-mobile/fenix/pull/26671/files includes changes to the border of un-selected wallpapers so the default wallpapers should be more visible once that lands.

Screenshot_20220907_151407

Screenshot_20220907_151501

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26870

@MatthewTighe MatthewTighe requested review from a team as code owners September 7, 2022 22:15
@sarah541
Copy link
Contributor

sarah541 commented Sep 7, 2022

@Kate-Galetski As per our meeting conversation, the overlay behind the wallpapers is removed in this PR

@MatthewTighe MatthewTighe added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 7, 2022
@mergify mergify bot merged commit 1eba805 into mozilla-mobile:main Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the layer behind the wallpaper thumbnails in the wallpaper settings screen.
2 participants