Bug 1796146 - Add UI for the Cookie Banner preferences

[owlishDeveloper]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

• QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

1. Click on Checks at the top of the PR page.
2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
3. Click on the build-debug task.
4. Click on View task in Taskcluster in the new DETAILS section.
5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

[owlishDeveloper]

Waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=1797142 (otherwise only the settings will be changed by this UI, the functionality itself will not be working)

[Amejia481]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How users interact with the cookie banners handling feature.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• This data will help us understand how the cookie banners handling feature is used.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• There are no other alternatives.


4. Can current instrumentation answer these questions?

• No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description	Data Collection Category	Tracking Bug #
When the cookie banners handling setting page is visited	Category 2 - interaction data	https://bugzilla.mozilla.org/show_bug.cgi?id=1796146
Which setting is selected	Category 2 - interaction data	https://bugzilla.mozilla.org/show_bug.cgi?id=1796146

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

• https://dictionary.telemetry.mozilla.org/apps/fenix


7. How long will this data be collected? Choose one of the following:

• Until version 118. Renewal then may be decided.

8. What populations will you measure?

• All channels, all locales, all countries
 that the feature is active for.

9. If this data collection is default on, what is the opt-out mechanism for users?

• Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.

• Glean and Amplitude.


11. Where do you intend to share the results of your analysis?

• 
Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?

• No third-party tools.

[mergify]

This pull request has conflicts when rebasing. Could you fix it @owlishDeveloper? 🙏

[Amejia481]

Looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1797142 already landed 🎉

[rocketsroger]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* How users interact with the cookie banners handling feature.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This data will help us understand how the cookie banners handling feature is used.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
When the cookie banners handling setting page is visited Category 2 - interaction data https://bugzilla.mozilla.org/show_bug.cgi?id=1796146
Which setting is selected Category 2 - interaction data https://bugzilla.mozilla.org/show_bug.cgi?id=1796146

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* Until version 118. Renewal then may be decided.


8. What populations will you measure?


* All channels, all locales, all countries
   that the feature is active for.


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end or be renewed by version 118

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

5. Is the data collection request for default-on or default-off?

default-on

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

[Amejia481]

In Fenix we don't support "Reject cookies if possible REJECT_ALL(1)" like in Focus ?

Yeah, based on the mockups it looks like Fenix will only have on setting REJECT_OR_ACCEPT_ALL(2).

[Amejia481]

If I unchecked "Reduce cookie banner," cookieBannerHandlingMode should be disabled, but when I go to a site that has a cookie banner, I don't see it . Only after I remove the app from the background and enter again do I see it.

Thanks for catching this, I think missed adding the reload for the current session.

[Amejia481]

Thanks for all the helpful comments @iorgamgabriel!
I updated the PR with your suggetions!

[iorgamgabriel]

Looks good to me! 👍

[sv-amocirean]

Hello,
This was verified by the mobile QA Team. See more details on Bugzilla.
Thanks!