Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1815160 - Add sponsored story id to home_recs_spoc_shown and home_recs_spoc_clicked #28796

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

Alexandru2909
Copy link
Contributor

Added sponsored story id to home_recs_spoc_shown and home_recs_spoc_clicked.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

@Alexandru2909 Alexandru2909 requested review from a team as code owners February 8, 2023 15:25
@Alexandru2909
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will help us understand how the Pocket sponsored stories feature is used and which sponsored Pocket stories are shown and interacted with.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This data will help us understand how users are interacting with the Pocket sponsored stories.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • No other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
User tapped a Pocket sponsored story to be opened Category 2 - interaction data 1815160
A particular Pocket sponsored story was visible more than 50% on the homescreen Category 2 - interaction data 1815160
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected?
  • The new probes are set to expire in version 119. Renewal may be considered at that point.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean.

  1. Where do you intend to share the results of your analysis?
  • 
Results will be shared through Glean with the mobile team and with the sponsored stories provider.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@Alexandru2909 Alexandru2909 added the needs:data-review PR is awaiting a data review label Feb 8, 2023
@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This data will help us understand how the Pocket sponsored stories feature is used and which sponsored Pocket stories are shown and interacted with.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This data will help us understand how users are interacting with the Pocket sponsored stories.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* No other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
User tapped a Pocket sponsored story to be opened Category 2 - interaction data 1815160
A particular Pocket sponsored story was visible more than 50% on the homescreen Category 2 - interaction data 1815160

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* https://dictionary.telemetry.mozilla.org/apps/fenix


7. How long will this data be collected?


* The new probes are set to expire in version 119. Renewal may be considered at that point.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean.


11. Where do you intend to share the results of your analysis?


* Results will be shared through Glean with the mobile team and with the sponsored stories provider.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end or be renewed by version 119

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger rocketsroger removed the needs:data-review PR is awaiting a data review label Feb 8, 2023
@rocketsroger rocketsroger added the pr:approved PR that has been approved label Feb 8, 2023
@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants