This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Issue #35: Handle device back button #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
suggested changes
May 4, 2018
| @@ -17,26 +17,38 @@ import mozilla.fenix.components.FeatureLifecycleObserver | |||
| import mozilla.fenix.ext.components | |||
|
|
|||
| class MainActivity : AppCompatActivity() { | |||
| private var toolbarFeature: ToolbarFeature? = null | |||
| private var sessionFeature: SessionFeature? = null | |||
There was a problem hiding this comment.
Instead of making this a nullable type we could make use of Kotlin's lateinit feature here:
https://kotlinlang.org/docs/reference/properties.html
In an activity it's pretty much standard that nothing happens before onCreate() is run. So I think we guarantee that those properties will never be actually null.
|
@pocmo OK, this is updated now! |
pocmo
approved these changes
May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.