Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add Tracking Protection Panel to the toolbar #4310

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Jul 26, 2019

Current state (DONE):

  • Adds Tracking Protection Panel with detailed list of trackers view (has new libstate and tests)
  • Modifies TrackingProtectionSettings to have strict/standard options under global TP setting
  • Modifies Core Engine TP policy for categories based on setting
  • Adds new assets (svgs, strings)
  • Onboarding
  • Learn more/description graphic in Settings

@Amejia481
Copy link
Contributor

@ekager you may want to take a look at :) (My draft for your draft) mozilla-mobile/android-components#3906

@ekager ekager force-pushed the enhanced-tracking-protection branch 7 times, most recently from 6a2ad67 to adecb3a Compare July 31, 2019 21:59
@ekager ekager force-pushed the enhanced-tracking-protection branch 3 times, most recently from 03d6ed8 to b181a55 Compare August 8, 2019 18:50
@ekager ekager force-pushed the enhanced-tracking-protection branch 4 times, most recently from 67cbdfa to eb7f069 Compare August 14, 2019 00:10
@ekager ekager mentioned this pull request Aug 14, 2019
4 tasks
@ekager ekager force-pushed the enhanced-tracking-protection branch from eb7f069 to d557a2a Compare August 15, 2019 18:57
@ekager ekager force-pushed the enhanced-tracking-protection branch from d557a2a to 64d5fea Compare September 6, 2019 22:27
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #4310 into master will increase coverage by 0.19%.
The diff coverage is 14.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4310      +/-   ##
============================================
+ Coverage     11.36%   11.55%   +0.19%     
- Complexity      232      238       +6     
============================================
  Files           235      243       +8     
  Lines          9265     9784     +519     
  Branches       1338     1415      +77     
============================================
+ Hits           1053     1131      +78     
- Misses         8144     8585     +441     
  Partials         68       68
Impacted Files Coverage Δ Complexity Δ
...zilla/fenix/settings/TrackingProtectionFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...src/main/java/org/mozilla/fenix/components/Core.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../trackingprotection/TrackingProtectionPanelView.kt 0% <0%> (ø) 0 <0> (?)
...ackingprotection/TrackingProtectionCategoryItem.kt 0% <0%> (ø) 0 <0> (?)
.../mozilla/fenix/customtabs/CustomTabsIntegration.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...lla/fenix/components/toolbar/ToolbarIntegration.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../fenix/trackingprotection/SwitchWithDescription.kt 0% <0%> (ø) 0 <0> (?)
...ozilla/fenix/settings/RadioButtonInfoPreference.kt 0% <0%> (ø) 0 <0> (?)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e83edc...44cf6a5. Read the comment docs.

@ekager ekager force-pushed the enhanced-tracking-protection branch 3 times, most recently from 2b18d36 to fc6f4bd Compare September 10, 2019 21:52
@ekager ekager marked this pull request as ready for review September 10, 2019 21:54
@ekager ekager requested review from a team as code owners September 10, 2019 21:54
@ekager
Copy link
Contributor Author

ekager commented Sep 10, 2019

OK I worked with @Amejia481 on this a bit today.

We need a tracking protection icon fix from the AC browser-state pr and an AC cookie category fix. For now we have commented out the Tracking Content and Cross-Site Tracking Cookies categories until we have better reporting available.

GV is working on a reporting patch that will align the logs directly with what desktop uses so we will have to do less guesswork here for which categories were the exact reasons something was blocked.

We think after we cut the Fenix release tomorrow, we should get this reviewed and merged so that we can start testing it in Nightly to find issues while waiting on the other fixes.

I've also added a feature flag so that the UI panel changes are only in nightly or debug builds, but chose to leave out the TP Settings Changes since we are confident in the new categories there.

@ekager ekager force-pushed the enhanced-tracking-protection branch 2 times, most recently from 9315148 to 28d4f21 Compare September 10, 2019 22:29
@ekager ekager requested a review from Amejia481 September 10, 2019 22:31
@Amejia481 Amejia481 self-requested a review September 11, 2019 02:19
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a few nits that don't block this from landing. Before merging let's squash the commits

@Amejia481 Amejia481 force-pushed the enhanced-tracking-protection branch from 28d4f21 to 1ea41de Compare September 11, 2019 03:50
@ekager ekager force-pushed the enhanced-tracking-protection branch 3 times, most recently from 4af6ff2 to f7023b0 Compare September 11, 2019 04:15
@Amejia481
Copy link
Contributor

Let's reword the commit to "Add Tracking Protection info panel"

@ekager ekager force-pushed the enhanced-tracking-protection branch from f7023b0 to 6cf499b Compare September 11, 2019 04:24
@ekager
Copy link
Contributor Author

ekager commented Sep 11, 2019

Haha I can type I swear 😆

@ekager ekager force-pushed the enhanced-tracking-protection branch from 6cf499b to c41be31 Compare September 11, 2019 04:37
@ekager ekager force-pushed the enhanced-tracking-protection branch from c41be31 to 44cf6a5 Compare September 11, 2019 04:49
@Amejia481 Amejia481 changed the title Add Tracking Protection Panel, Tweak TP Settings Add Tracking Protection Panel to the toolbar Sep 11, 2019
@ekager ekager merged commit 4485b7f into mozilla-mobile:master Sep 11, 2019
@ekager ekager deleted the enhanced-tracking-protection branch September 11, 2019 14:47
@Amejia481
Copy link
Contributor

🚀 🛡

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants