-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Tracking Protection Panel to the toolbar #4310
Add Tracking Protection Panel to the toolbar #4310
Conversation
app/src/main/java/org/mozilla/fenix/settings/TrackingProtectionFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt
Outdated
Show resolved
Hide resolved
@ekager you may want to take a look at :) (My draft for your draft) mozilla-mobile/android-components#3906 |
app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/RadioButtonPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/RadioButtonInfoPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TrackingProtectionFragment.kt
Show resolved
Hide resolved
6a2ad67
to
adecb3a
Compare
03d6ed8
to
b181a55
Compare
67cbdfa
to
eb7f069
Compare
eb7f069
to
d557a2a
Compare
d557a2a
to
64d5fea
Compare
Codecov Report
@@ Coverage Diff @@
## master #4310 +/- ##
============================================
+ Coverage 11.36% 11.55% +0.19%
- Complexity 232 238 +6
============================================
Files 235 243 +8
Lines 9265 9784 +519
Branches 1338 1415 +77
============================================
+ Hits 1053 1131 +78
- Misses 8144 8585 +441
Partials 68 68
Continue to review full report at Codecov.
|
2b18d36
to
fc6f4bd
Compare
OK I worked with @Amejia481 on this a bit today. We need a tracking protection icon fix from the AC browser-state pr and an AC cookie category fix. For now we have commented out the Tracking Content and Cross-Site Tracking Cookies categories until we have better reporting available. GV is working on a reporting patch that will align the logs directly with what desktop uses so we will have to do less guesswork here for which categories were the exact reasons something was blocked. We think after we cut the Fenix release tomorrow, we should get this reviewed and merged so that we can start testing it in Nightly to find issues while waiting on the other fixes. I've also added a feature flag so that the UI panel changes are only in |
9315148
to
28d4f21
Compare
app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a few nits that don't block this from landing. Before merging let's squash the commits
28d4f21
to
1ea41de
Compare
4af6ff2
to
f7023b0
Compare
Let's reword the commit to "Add Tracking Protection info panel" |
f7023b0
to
6cf499b
Compare
Haha I can type I swear 😆 |
6cf499b
to
c41be31
Compare
c41be31
to
44cf6a5
Compare
🚀 🛡 |
Current state (DONE):