Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4658: Add private browsing mode shortcut telemetry #5194

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

jyeontaek
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 10, 2019
@jyeontaek jyeontaek marked this pull request as ready for review September 11, 2019 20:18
@jyeontaek jyeontaek requested review from a team as code owners September 11, 2019 20:18
@jyeontaek jyeontaek added needs:data-review PR is awaiting a data review and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Sep 11, 2019
@jyeontaek jyeontaek requested a review from boek September 11, 2019 20:19
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #5194 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5194      +/-   ##
============================================
- Coverage     11.55%   11.52%   -0.03%     
- Complexity      239      240       +1     
============================================
  Files           244      244              
  Lines          9954     9979      +25     
  Branches       1447     1453       +6     
============================================
  Hits           1150     1150              
- Misses         8733     8758      +25     
  Partials         71       71
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 0.82% <0%> (-0.05%) 1 <0> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 21.57% <0%> (-0.71%) 0 <0> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...la/fenix/home/intent/StartSearchIntentProcessor.kt 73.33% <0%> (-18.34%) 5 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e66f...7885faa. Read the comment docs.

@jyeontaek jyeontaek added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 11, 2019
@jyeontaek
Copy link
Contributor Author

jyeontaek commented Sep 11, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • Whether or not users add Private Browsing Shortcut
  • Which shortcuts (long-press and pinned) are users interacting with the most
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Since Focus will be sunset, the initial data retrieved from Fenix users will help us understand if the private mode features are discoverable/useful. Going forward, if we detect discoverability issues, changes can be made for the onboarding on Focus users.

  • The benefits mostly revolve around our product being fast/private by design. Will promote safety when browsing the web and opening 3rd party links.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@jyeontaek jyeontaek removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 11, 2019
app/metrics.yaml Show resolved Hide resolved
app/metrics.yaml Show resolved Hide resolved
app/metrics.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small nits around naming. Other than that looks good!

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, metrics.md and metrics.yaml

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Fenix PM Vesta will monitor, and this has an expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, interaction with search UI
5) Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry, 3/2020

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@boek boek merged commit ddc1b2e into mozilla-mobile:master Sep 11, 2019
@jyeontaek jyeontaek modified the milestone: v2.0 Sep 11, 2019
pocmo added a commit to pocmo/fenix that referenced this pull request Feb 14, 2020
Reusing the same taskAffinity makes sure that we are launching into a potentially already
existing task from Fennec. Without that we may spawn a new task and will show up twice
in "Recent apps" - with one entry still having a fennec screenshot.
pocmo added a commit that referenced this pull request Feb 17, 2020
Reusing the same taskAffinity makes sure that we are launching into a potentially already
existing task from Fennec. Without that we may spawn a new task and will show up twice
in "Recent apps" - with one entry still having a fennec screenshot.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants