-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #4658: Add private browsing mode shortcut telemetry #5194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
============================================
- Coverage 11.55% 11.52% -0.03%
- Complexity 239 240 +1
============================================
Files 244 244
Lines 9954 9979 +25
Branches 1447 1453 +6
============================================
Hits 1150 1150
- Misses 8733 8758 +25
Partials 71 71
Continue to review full report at Codecov.
|
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small nits around naming. Other than that looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.md and metrics.yaml
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Fenix PM Vesta will monitor, and this has an expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, interaction with search UI
5) Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry, 3/2020
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
Reusing the same taskAffinity makes sure that we are launching into a potentially already existing task from Fennec. Without that we may spawn a new task and will show up twice in "Recent apps" - with one entry still having a fennec screenshot.
Reusing the same taskAffinity makes sure that we are launching into a potentially already existing task from Fennec. Without that we may spawn a new task and will show up twice in "Recent apps" - with one entry still having a fennec screenshot.
Pull Request checklist