-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5197: Adds telemetry for media controls #5266
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
11ddc60
to
6e2ba8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5266 +/- ##
============================================
- Coverage 12.76% 12.75% -0.01%
Complexity 277 277
============================================
Files 251 251
Lines 10328 10336 +8
Branches 1504 1506 +2
============================================
Hits 1318 1318
- Misses 8921 8929 +8
Partials 89 89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs data review. 1 nit for other code
6e2ba8c
to
1ae5fbd
Compare
1ae5fbd
to
57edd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, documented in metrics.yaml
, and generated metrics.md
is included.
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Expires in 3/2020
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, user interactions w/ media controls on the homescreen
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, just interactions w/ UI, no extras
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry
- Does the data collection use a third-party collection tool?
No
Pull Request checklist
After merge