Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

(Fixing breaking API changes) "Choose what to sync" integration work #5450

Merged
merged 2 commits into from
Sep 30, 2019
Merged

(Fixing breaking API changes) "Choose what to sync" integration work #5450

merged 2 commits into from
Sep 30, 2019

Conversation

grigoryk
Copy link
Contributor

@grigoryk grigoryk commented Sep 20, 2019 •
edited
Loading

Fixes #2157.

This PR is built on top of WIP changes in a-c: mozilla-mobile/android-components#4480

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@grigoryk grigoryk mentioned this pull request Sep 20, 2019
Merged
6 tasks
@Amejia481
Copy link
Contributor

Looks Good 👍

@ekager ekager mentioned this pull request Sep 24, 2019
Closed
@liuche liuche mentioned this pull request Sep 25, 2019
Closed
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request Sep 27, 2019
@MozLando
Merge #4480
83ffd01 
4480: Closes #2727: Rust SyncManager integration r=csadilek a=grigoryk

Fixes #2727.
This has most of the pieces in the right places.
I think all of the necessary public API changes are done.

It mostly works, except that I've hit some bugs in the rust library:
- mozilla/application-services#1831 (blocker)
- mozilla/application-services#1829 (minor)

Fenix PR that enables "choose what to sync" on top of this: mozilla-mobile/fenix#5450



Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
@grigoryk grigoryk marked this pull request as ready for review September 27, 2019 19:46
@grigoryk
Copy link
Contributor Author

This can land once mozilla-mobile/android-components#4480 makes it into the snapshot.

@Amejia481
Copy link
Contributor

@grigoryk before lading this do we need a data-review?

@grigoryk
Copy link
Contributor Author

No, no new data is being collected.

pocmo
pocmo approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Landing to fix breaking API changes on master with the latest snapshots.

@pocmo pocmo changed the title "Choose what to sync" integration work (Fixing breaking API changes) "Choose what to sync" integration work Sep 30, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 30, 2019

Landing to fix breaking API changes on master with the latest snapshots.

Well, I'll retrigger the PR first. :)

@ekager
Copy link
Contributor

ekager commented Sep 30, 2019

Detekt failing on

ComplexMethod - 10/10 - [onCreatePreferences] at /builds/worker/checkouts/src/app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt:101:5

and test-debug failing on

e: /builds/worker/checkouts/src/app/src/test/java/org/mozilla/fenix/components/BackgroundServicesTest.kt: (61, 41): Unresolved reference: HISTORY
e: /builds/worker/checkouts/src/app/src/test/java/org/mozilla/fenix/components/BackgroundServicesTest.kt: (61, 61): Unresolved reference: BOOKMARKS

Grisha Kruglov and others added 2 commits September 30, 2019 09:06
@Amejia481 @ekager
FxA WebChannels integration
6fea12b 
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes mozilla-mobile#4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@ekager
Update BackgroundServicesTest, Suppress Complex Method
1b74088
@sblatz sblatz mentioned this pull request Sep 30, 2019
Closed
@ekager ekager merged commit ef29fe2 into mozilla-mobile:master Sep 30, 2019
@grigoryk grigoryk deleted the fxaApis branch September 30, 2019 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

@colintheshots colintheshots colintheshots approved these changes

@pocmo pocmo pocmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable selection of what to sync
5 participants
@grigoryk @Amejia481 @pocmo @ekager @colintheshots