Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1580778 - Fix duplicated scopes #5515

Merged

Conversation

JohanLorenzo
Copy link
Contributor

Fixes https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268142889&repo=fenix&lineNumber=11

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@JohanLorenzo JohanLorenzo requested review from a team as code owners September 24, 2019 12:21
@JohanLorenzo JohanLorenzo merged commit 01f3c85 into mozilla-mobile:master Sep 24, 2019
@JohanLorenzo JohanLorenzo deleted the fix-duplicated-scopes branch September 24, 2019 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants